Follow-up: Check for custom display setting before altering.

I agree, thank you for the report.

hass,

The simplest solution would be to replace in taxonomy_display_fetch_taxonomy_display():

This:

$result = db_select('taxonomy_display', 'td')
  ->fields('td')
  ->condition('machine_name', $machine_name)
  ->execute()
  ->fetchAssoc();

With this:

$result = FALSE;
if (condition to check if enabled) {
  $result = db_select('taxonomy_display', 'td')
      ->fields('td')
      ->condition('machine_name', $machine_name)
      ->execute()
      ->fetchAssoc();
}

Note that taxonomy_display does run on every taxonomy term page load. There's no way to selectively hook_menu_alter() on specific vocabularies.

I can confirm this. I agree that this is a usability issue.

I'm not concerned about any performance hit that checking like this will cause, it seems like it should be minor. If we find it's needed, we can add a layer of cache here at some point in the future.

Still needs a patch to get RTBC.

Please review against 7.x-1.x.

Committed to 7.x-1.x

While this is committed, it's introduced a problem.

On a fresh site, before any mode is either set or not set, field_view_mode_settings() will return an empty array. This causes a warning when we test for custom settings.

Committed a fix.

Also, now that this is in, anyone importing taxonomy_display settings via Features will also need to have exported their bundle settings for the vocabulary (this is a variable, so requires Strongarm) or have manually enabled the custom display for the exported taxonomy_display settings to have any effect.

We should probably document the Features export process (including the strongarm and manual option) in a new child page of: http://drupal.org/node/1254876 before the 1.1 release.