Selecting Views in Associated content display shows me empty select options.

<select id="edit-additional-settings-taxonomy-display-associated-display-form-view" name="additional_settings[taxonomy_display][associated_display_form][view]" class="form-select ajax-processed">
	<option value="calendar_events">Events</option>
	<option value="foo">My Foo</option>
	<option value="workbench_access_content"></option>
	<option value="workbench_current_user"></option>
	<option value="workbench_edited"></option>
	<option value="workbench_files"></option>
	<option value="workbench_moderation">workbench_moderation</option>
	<option value="workbench_recent_content"></option>
</select>
CommentFileSizeAuthor
#6 1507632_Taxonomy_Display_Display+select+option+for+views+that+do+not+have+a+human+name+set.patch912 byteshass
#4 taxonomy_display-empty-select-options-1507632-4.patch1.63 KBcodycraven

Comments

codycraven’s picture

codycraven commented
Status: Active » Postponed (maintainer needs more info)

hass, I could use some additonal details on these broken select options.

First I'd like to know what version of Views you are using, to see if this is a recent incompatibility issue in the way I populate the options based on the response from Views.

Second, looking at the list of items that have this issue it appears they are all "workbench_". Are these from the Workbench module? If so this could be a problem in their Views exported to code.

Note that even if this is a problem with the Views from a specific module I'd still like to fix the problem to at least populate the View's machine name as the selectable option, as it's far better than an empty option.

Lastly, could you visit one of the views that isn't working, such as workbench_recent_content, and tell me what the name is for the View? I'm suspecting it's not populated, which I didn't believe was possible (unless of course it's because the exported to code View has been modified to a broken state).

hass’s picture

hass commented

Yep, Workbench Suite... it's up to 5 modules.

In views interface the machine name seems to be shown as name. I cannot see the name field not filled in Views settings... so it may be better if you just try it yourself so I'm not telling you anything wrong...

codycraven’s picture

codycraven commented
Status: Postponed (maintainer needs more info) » Needs work
codycraven’s picture

codycraven commented
Assigned: Unassigned » codycraven
Status: Needs work » Needs review
StatusFileSize
new taxonomy_display-empty-select-options-1507632-4.patch1.63 KB

hass,

Sorry about the incredible delay, work has keep me pretty busy as of late. Please find that attached patch and let me know if it solves the problem.

hass’s picture

hass commented
Status: Needs review » Needs work

Patch does not apply. You are able to enable automated tests on the modules page...

hass’s picture

hass commented
Version: 7.x-1.0 » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new 1507632_Taxonomy_Display_Display+select+option+for+views+that+do+not+have+a+human+name+set.patch912 bytes

I'm attaching a slightly optimized patch that applies to DEV. I have tested it and it works as advertised. RTBC.

codycraven’s picture

codycraven commented
Status: Needs review » Fixed

Committed and pushed to dev branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.