Download & Extend

Add the ability to have a label for jump menu selector fields

Project:Chaos tool suite (ctools)
Version:8.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:accessibility

Issue Summary

When you have a jump menu view there is no way to get a label for the jump selector, which is required for accessibility reasons.

It would be good to add a label setting where users could enter the label text (or leave it blank if they still do not want a label).
It would default to blank so as not to break existing sites.

Comments

#1

Status:active» needs review

Here is a patch to add the option.

AttachmentSizeStatusTest resultOperations
views-jump_menu_label-1507854-1.patch1.56 KBIdlePASSED: [[SimpleTest]]: [MySQL] 1,338 pass(es).View details

#2

Status:needs review» needs work

If we add some kind of feature to the normal jump_menu style it should be added to the summary one as well, so you have to change views_plugin_style_summary_jump_menu.

This shouldn't be hard.as well, but this

#3

Patch worked for me, thanks. Needed it for exactly the same reason.

#4

Status:needs work» needs review

Here's a patch with the change to views_plugin_style_summary_jump_menu(). It should be pretty identical so I just basically cut/paste it in.

AttachmentSizeStatusTest resultOperations
views-jump_menu_label-1507854-4.patch3.19 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-jump_menu_label-1507854-4.patch. Unable to apply patch. See the log in the details link for more information.View details

#5

tagging

#6

Version:7.x-3.x-dev» 8.x-3.x-dev
Issue tags:+VDC

Push to d8 to fix it there first.

#7

Project:Views» Chaos tool suite (ctools)
Version:8.x-3.x-dev» 8.x-1.x-dev
Status:needs review» patch (to be ported)

Oh well, this part does not exist in d8 anymore, move back.

For the d8 port of the patch we should better add a test for that new functionality.

Congrats rooby for your first commit to views! Thanks! Committed and pushed.

#8

Issue tags:-VDC

Remove the VDC tag.

#9

Thanks for the updated version mgifford.

#10

Status:patch (to be ported)» needs review

#4: views-jump_menu_label-1507854-4.patch queued for re-testing.

#11

Status:needs review» needs work

The last submitted patch, views-jump_menu_label-1507854-4.patch, failed testing.

#12

Status:needs work» closed (fixed)

To anyone looking for this functionality, this has been fixed on the latest dev version as of October 7th.

nobody click here