When you have a jump menu view there is no way to get a label for the jump selector, which is required for accessibility reasons.

It would be good to add a label setting where users could enter the label text (or leave it blank if they still do not want a label).
It would default to blank so as not to break existing sites.

Comments

rooby’s picture

Status: Active » Needs review
StatusFileSize
new1.56 KB

Here is a patch to add the option.

dawehner’s picture

Status: Needs review » Needs work

If we add some kind of feature to the normal jump_menu style it should be added to the summary one as well, so you have to change views_plugin_style_summary_jump_menu.

This shouldn't be hard.as well, but this

alimac’s picture

Patch worked for me, thanks. Needed it for exactly the same reason.

mgifford’s picture

Status: Needs work » Needs review
StatusFileSize
new3.19 KB

Here's a patch with the change to views_plugin_style_summary_jump_menu(). It should be pretty identical so I just basically cut/paste it in.

mgifford’s picture

Issue tags: +Accessibility

tagging

dawehner’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev
Issue tags: +VDC

Push to d8 to fix it there first.

dawehner’s picture

Project: Views (for Drupal 7) » Chaos Tool Suite (ctools)
Version: 8.x-3.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Oh well, this part does not exist in d8 anymore, move back.

For the d8 port of the patch we should better add a test for that new functionality.

Congrats rooby for your first commit to views! Thanks! Committed and pushed.

dawehner’s picture

Issue tags: -VDC

Remove the VDC tag.

rooby’s picture

Thanks for the updated version mgifford.

mgifford’s picture

Status: Patch (to be ported) » Needs review
Issue tags: -Accessibility

Status: Needs review » Needs work
Issue tags: +Accessibility

The last submitted patch, views-jump_menu_label-1507854-4.patch, failed testing.

wbobeirne’s picture

Status: Needs work » Closed (fixed)

To anyone looking for this functionality, this has been fixed on the latest dev version as of October 7th.

dalin’s picture

Version: 8.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Closed (fixed) » Patch (to be ported)

If I'm following the thread correctly, this still needs to be ported to D7.

mgifford’s picture

The changes both look like they are applied to the Views module rather than ctools. Should the project be changed for this?

https://api.drupal.org/api/views/plugins!views_plugin_style_jump_menu.inc/7
https://api.drupal.org/api/views/plugins!views_plugin_style_summary_jump...

la558’s picture

@dawehner: re- your post #7
Has it ever been a solution for D8
I'm at the below folder structure, but I don't see the equivalent to 'views_plugin_style_jump_menu.inc' on D7 (modules > views > plugins)

core > modules > views > src > Plugin > views > (I checked 'style' and other directories in here)

Thanks!

japerry’s picture

Status: Patch (to be ported) » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.