In config_install_default_config I think we can replace three lines that extract config name from filename with a single line using http://us3.php.net/basename

CommentFileSizeAuthor
#4 cmi_base_name.patch674 bytesmarcingy
cmi_install_config_basename.patch774 bytesRok Žlender

Comments

Status: Needs review » Needs work
Issue tags: -Configuration system

The last submitted patch, cmi_install_config_basename.patch, failed testing.

Rok Žlender’s picture

Rok Žlender commented
Status: Needs work » Needs review

cmi_install_config_basename.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Configuration system

The last submitted patch, cmi_install_config_basename.patch, failed testing.

marcingy’s picture

marcingy commented
Status: Needs work » Needs review
StatusFileSize
new cmi_base_name.patch674 bytes

We need a little bit more but this still tidies up the code a little bit.

ksenzee’s picture

ksenzee
she/her
commented

Does anyone know why the first patch didn't work? I would think it should have.

Rok Žlender’s picture

Rok Žlender commented

Yes. I removed a variable that is needed later on in that function.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Closed (duplicate)

This has been fixed via #1470824: XML encoder can only handle a small subset of PHP arrays, so switch to YAML already.