Order comments in digest by node type needs $comment->nid as oid in notifications_event [#1508498]

Hi,

I want to order comments in digest by node type. So i need the nid in notifications_event.

I did a patch in notifications_content.module to add it to the saved event.

Is there a reason why wa shouldn't have nid in oid field as we have for node insert ?

Could you add it please ? patch will follow.

Comment	File	Size	Author
#2	notifications_content-Order_comments_in_digest_by_node_type-1508498-2.patch	1.69 KB	chipway
#1	notifications_content-Order_comments_in_digest_by_node_type-1508498-1.patch	615 bytes	chipway

Comments

chipway commented 30 March 2012 at 08:07

Status:

Active

» Needs review

Status	File	Size
new	notifications_content-Order_comments_in_digest_by_node_type-1508498-1.patch	615 bytes

Patch to add $comment->nid as oid in notifications_event :

notifications_content-Order_comments_in_digest_by_node_type-1508498-1.patch

Could you review it and apply if no side effect as stated above?

Tks

chipway commented 30 March 2012 at 10:52

Status	File	Size
new	notifications_content-Order_comments_in_digest_by_node_type-1508498-2.patch	1.69 KB

In order to be allowed to rewrite the $sql in notifications.cron.inc on lines 200+

We wrap the $sql in db_query_sql().

Here is the patch that do this.

Please review.

chipway commented 30 March 2012 at 14:28

Status:

Needs review

» Closed (won't fix)

May be not really useful.

Changing status.