Great module!

Minor bug: Manually awarding an achievement to a user that does not have permission to earn achievements returns a message that the achievement was unlocked when it isn't.

Possible fix attached.

CommentFileSizeAuthor
rkimmons-check-user-access.patch901 bytesRoyce Kimmons

Comments

Royce Kimmons’s picture

Royce Kimmons commented

On a related note, any particular reason you use drupal_set_message and returns in the submit function instead of using form_set_error in a validation function?

Just wondering aloud.

morbus iff’s picture

morbus iff
they/them
commented

Thanks for the patch! Bizarrely, I didn't get an email notification about this one (not sure why), but I'll take a look at it in more detail later.

morbus iff’s picture

morbus iff
they/them
commented
Status: Needs review » Fixed

Committed.

(Incidentally, the #validate is a good point. Will have to remember to revise that in a different issue.)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.