See dmemcache.inc lines 308::314

  if ($flush) {
    foreach ($memcacheCache as $cluster) {
      memcache_close($cluster);
    }
    $memcacheCache = array();
  }

It appears that we can just convert this to use the OO ->close(); method instead of the procedural. Will test this in-practice. Appears to be an issue in the D6 version of this module as well-- seems no one calls dmemcache_obj($bin, $flush == TRUE)?

CommentFileSizeAuthor
#1 7.x-1.x-memcache_flush.patch683 bytesjosh waihi

Comments

josh waihi’s picture

josh waihi commented
Title: memcache_close() not defined. Called in dmemcache_object if $flush == TRUE » Remove memcache extension dependency in dmemcache.inc
Status: Active » Needs review
StatusFileSize
new 7.x-1.x-memcache_flush.patch683 bytes

There are two areas in dmemcache.inc that still explicity use memcache procedural functions instead of object calls of dmemcache_object($bin). Attached is a patch that fixes breakages when the memcached extension is used instead of memcache.

  • Jeremy committed 235640a on 7.x-1.x 
    Issue #1508574 by Jeremy: Remove memcache extension dependency in...

  • Jeremy committed 6fdf224 on 7.x-1.x 
    Issue #1508574 by Jeremy: Fix documentation
jeremy’s picture

jeremy commented
Issue summary: View changes
Status: Needs review » Fixed

This was never actually an issue as these functions weren't exposed, but a recently added Drush command exposes the flush. Went ahead and fixed both.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.