Hi Fabio,

I think I have an issue for you to look at. I am unable to attach/upload video thumbnails to video nodes when creating or editing. I do not get an error, but the file does not appear to upload to it's location in the /files directory. After attaching the thumbnail, refreshing the page, there is not thumb displayed. When I return to edit the node, it seems like there was no thumbnail attached at all.

I can't tell, but maybe this error message is part of the problem. Its comes from my error log at about the same time I was experiencing the problem.

I've reinstalled the module a few times, tampered with the settings, but still I cannot solve it.

Interesting also, I cannot make the image_attach module connect any files to my video nodes.

Do you have any idea what could be causing this? If its the first time you have heard of this then I would be happy to give you access to my server again. Maybe if you saw the bad behavior then you would know how to solve this puzzle.

Thanks for all your help over this last year!

Sean

CommentFileSizeAuthor
#8 konqueror_hide.patch831 bytesfax8
#5 video_image.module.patch4.23 KBvangorra

Comments

seaneffel’s picture

seaneffel commented

I think something about the "submit" action is not properly performing the video_image upload. I can perform all these functions on other node types without a problem.

fax8’s picture

fax8 commented

Sometimes attached images get deleted during node editing.. it is a known bug and it should be reported on this issue queue..

If you have some time please try to fix this.

Thanks.

seaneffel’s picture

seaneffel commented

I am not sure I understand.

My issue is that images are not uploaded at all. video_image and image_attach both fail to upload image files to video nodes. The video_image module presents a perfect UI but after each submit the thumbnail data is lost and no file is uploaded. I am able to assign existing image_attach thumbnails, but not create new ones.

seaneffel’s picture

seaneffel commented

I tried some of the tricks you suggested in your email, Fabio, but the patch listed here did not solve the issue. None of the behavior has changed and I reverted back to the original files. I will try to hire a code sharpshooter who can hunt down this bug and kill it for me. I'll contribute the solution back as best I can.

Just for good record keeping, the patch suggested was here:
http://drupal.org/files/issues/do_not_use_session_variable_2.patch

vangorra’s picture

vangorra commented
StatusFileSize
new video_image.module.patch4.23 KB

I've encountered the same problem. I have written a patch to do solve the problem. Keep me posted.

This patch also provides a system option to delete the previous thumbnail when a new one is provided. The optimal solution would be to change the image node itself, but we need to start somewhere.
Enjoy!

seaneffel’s picture

seaneffel commented

This doesn't solve my specific problem, but I can see your changes to the video_image module and I like it.

seaneffel’s picture

seaneffel commented

More information after some testing. It seems I've run into a Safari browser bug.

Vangorra pointed out this issue: http://neurofuzzy.net/2006/04/24/safari-php-and-file-uploads/

Safari breaks the upload when the certain form items are marked as "hidden" in their css values. Some people have found workarounds for their applications by changing those values on the forms. Read here: http://www.neurofuzzy.net/2006/07/09/safari-and-php-file-uploads-solved/

Are these things that can be resolved in the video_image module to make it play better with Safari? I understand Fax8 is working on a new video.module release, maybe this would be a consideration?

BTW, Vangorra's patch adds a really nice feature to replace the thumbnail file when uploading a new one, rather than to store expired thumbnails on the server. Good house keeping, I suggest this patch gets reviewed and committed.

fax8’s picture

fax8 commented
StatusFileSize
new konqueror_hide.patch831 bytes

During the rewrite I'm working on I found something similar with Konqueror.
When the video_upload plugin is active, once the user submit the video the form is
hided and a busy status message is displayed. Unfortunately this break file upload
because Konqueror does not pass file values for hidden forms. I fixed it changing a bit
the javascript which hide the form ...

As Safari is Based on the same Koqueror code this could be related to your issue.

Please give a try to the attached patch.

seaneffel’s picture

seaneffel commented

Fabio,

I've been testing the above video_upload.patch file. Indeed, thw two versions of Safari are not causing upload failures like they used to. I've got access to Safari 1.3.4 and 2.0.4 or some such, and this is what I find.

  • Safari now correctly correctly creates new video nodes and uploads video files.
  • Safari also correctly inserts thumbnails both manually and through ffmpeg.
  • Safari no longer deletes thumbnails when editing the video node.

I am not yet confirmed that Safari no longer deletes video files randomly when editing the node, I have to do some deeper tests. But I have a hunch its been solved. As some more time elapses in our operations over here then I'll report back.

If you are confident, can this patch be added to your dev release?

fax8’s picture

fax8 commented
Status: Active » Fixed

I have fixed this behavior in my rewrite. going to publish it soon.

Fabio

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
seaneffel’s picture

seaneffel commented

I have to append my evaluation of the changes here to say that thumbnail images are behaving poorly again. I noticed that when I turned on the Spam module it recommended that I make all node creation to require the "preview" step in order to properly filter for potential spam before it is published. Now I notice that when I attach a video thumbnail image and preview that the file I selected for a thumbnail is no longer selected and I have to select again and submit.

I am not willing to let things submit without the preview step, we get too much spam. How can we ensure that the file will still be attached after the preview stage?

And does this same fix need to be applied to the selected video file to be retained from preview to submit?

If anyone in the know wants to check out our server and configuration from an admin account, please let me know and we can work that out. Especially if it helps strengthen this module, its a really good one. Thanks!