The attached patch improves the title of the field mapping edit page by using the PDF key when there is no label set and prefixing it with "Edit field mapping for".

CommentFileSizeAuthor
#1 fillpdf_1508674_field_mapping_title_2.patch608 byteswizonesolutions
fillpdf_field_mapping_title.patch591 bytesliam morland

Comments

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new fillpdf_1508674_field_mapping_title_2.patch608 bytes

I've committed the following modified version. I think we should be using title callback within the actual fillpdf_menu() entry, but this is fine for starters. Moving it to title callback could be a separate issue.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Assigned: liam morland » Unassigned
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks. I put "Edit field mapping for" in an em element for consistency with "Edit Web Page".

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Where is that found? I figured, in any case, that italicizing could be done with CSS if needed.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Click on the edit link on a regular page on your site. The HTML inside the h1 of the edit page will be:

<em>Edit Basic page</em> Page Title

I was following that example.

It just occurred to me that there could be a theming function that does this.

  • Commit a213e66 on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest authored by Liam Morland, committed by wizonesolutions: 
    Issue #1508674: Set title to something more descriptive.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

Drupal 6 is no longer supported.