When running Drush Make I am able to use a multitude of libraries however for some reason I am unable to get the CKEditor library. The syntax in the make file is as follows:

libraries[ckeditor][download][type] = "file"
libraries[ckeditor][download][url] = "http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.2/ckeditor..."

I should mention this is on a windows machine using drush for windows + msysgit. I will be trying at home on Linux to see if problem exists there as well.

Also drush itself does not give an error and says the library has been downloaded successfully.

---

As per below comment think this is the problem from drush debug output:

Executing: curl -s -L --connect-timeout 30 -o "C:\\Users\\username\\AppData\\Local\\Temp\\dow9D77.tmp" "http://download.cksource.com/CKEditor/CKEditor/CKEditor%%203.6.3/ckedito..."

Where in the link the space character %20 now says %%20.

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Postponed (maintainer needs more info)

I think this may be a duplicate of #1490714: Single file libraries with incorrect names, which was fixed earlier today. Can you try the latest version on master and let me know if this fixes the issue?

sylus’s picture

sylus commented
Issue summary: View changes

New

sylus’s picture

sylus commented
Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Active

Hey the problem still exists in latest Drush.ws release (5.1) as of April 17th, 2012.

I think I have located the problem. In the drush make file the url for ckeditor is: http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.3/ckeditor...

If you look at the drush make debug output you see curl represents this as the following:

Executing: curl -s -L --connect-timeout 30 -o "C:\\Users\\username\\AppData\\Local\\Temp\\dow9D77.tmp" "http://download.cksource.com/CKEditor/CKEditor/CKEditor%%203.6.3/ckedito..."

Where in the link the space character %20 now says %%20.

This would mean with current drush make on windows (possibly linux) all urls that have a space in them encoding with %20 will fail when trying to build.

sylus’s picture

sylus commented
Issue summary: View changes

Modified

sylus’s picture

sylus commented
Issue summary: View changes

Mod

sylus’s picture

sylus commented

Hey wondering if there is any more information I can provide to get the ball rolling. I would even attempt a patch if someone could point me in the right direction to look :)

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Could you provide any relevant output from running drush make with the --debug option set?

sylus’s picture

sylus commented

Contents of Drush Make

libraries[ckeditor][download][type] = "get"
libraries[ckeditor][download][url] = "http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.3/ckeditor..."
libraries[ckeditor][directory_name] = "ckeditor"
libraries[ckeditor][type] = "library"

The only relevant information that debug gives me is:

Executing: curl -s -L --connect-timeout 30 -o "C:\\Users\\username\\AppData\\Local\\Temp\\dow9D77.tmp" "http://download.cksource.com/CKEditor/CKEditor/CKEditor%%203.6.3/ckedito..."

Where in the link the space character %20 now says %%20.

sylus’s picture

sylus commented

I should mention this only happens in Windows. Also here is some of the debug output:

$ drush make --no-core webexp.make test_build --debug
Bootstrap to phase 0. [0.03 sec, 2.43 MB] [bootstrap]

Drush bootstrap phase : _drush_bootstrap_drush() [0.04 sec, 2.58 MB] [bootstrap]

Loading drushrc "C:\Users\username\.drush\drushrc.php" into [bootstrap]

"home.drush" scope. [0.13 sec, 2.58 MB]
Cache HIT cid: 5.1-commandfiles-0-af3c1b5cbfaa3ad27e77bd15ed84de6f [debug]

[0.14 sec, 2.59 MB]
Bootstrap to phase 0. [0.18 sec, 5.46 MB] [bootstrap]

Bootstrap to phase 0. [0.19 sec, 5.47 MB] [bootstrap]

Found command: make (commandfile=make) [0.19 sec, 5.47 MB] [bootstrap]

Loading release_info engine. [0.2 sec, 5.48 MB] [notice]

Executing: which wget
'which' is not recognized as an internal or external command,
operable program or batch file.
Executing: curl -s -L --connect-timeout 30 -o "C:\\Users\\username\\AppData\\Loca
l\\Temp\\dowC73C.tmp" "http://download.cksource.com/CKEditor/CKEditor/CKEditor%%
203.6.3/ckeditor_3.6.3.tar.gz"
Calling is_readable(C:\Users\username\AppData\Local\Temp\dowC73C.tmp) [debug]

[1.33 sec, 5.63 MB]
Calling [debug]

Again notice the double %% in the url.

sylus’s picture

sylus commented

Would anyone have a possible solution or workaround for this?

kylesmith’s picture

kylesmith commented

I am able to get the CKEditor library with a make file using drush version 5.4 on Windows XP for a Drupal 7.x core.

Some of the output from the --debug option:

Executing: curl -s -L --connect-timeout 30 -o "C:\\Documents and Settings\\username\\Local Settings\\Temp\\dow110A.tmp" "http://download.cksource.com/CKEditor/CKEditor/CKEditor%%203.6.3/ckeditor_3.6.3.tar.gz"
'curl' is not recognized as an internal or external command, operable program or batch file.
...
ckeditor downloaded from "http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.3/ckeditor_3.6.3.tar.gz".
Executing: gzip --list "C:\\DOCUME~1\\username\\LOCALS~1\\Temp/make_tmp_1344009764_501bf624c5ffa/ckeditor_3.6.3.tar.gz"
Executing: gzip -d "C:\\DOCUME~1\\username\\LOCALS~1\\Temp/make_tmp_1344009764_501bf624c5ffa/ckeditor_3.6.3.tar.gz"

I too have the space character %20 as %%20 in the 'curl' command, but the debug also says 'curl' is not recognized as an internal or external command, so I am still getting the CKEditor without it.

My make file includes the lines:

projects[ckeditor][version] = "1.6"
projects[wysiwyg][version] = "2.1"
libraries[ckeditor][download][type] = "get"
libraries[ckeditor][download][url] = "http://download.cksource.com/CKEditor/CKEditor/CKEditor%203.6.3/ckeditor_3.6.3.tar.gz"

I originally had trouble by dowloading the ckeditor_3.6.3.zip, but have had no issues since switching to the .tar.gz file.

sylus’s picture

sylus commented
Status: Active » Fixed

Thanks @kylesmith does seem resolved now :) setting to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Mod