People can delete field mappings, but not add them. It seems to me that they should either be able to do both or neither, and neither makes more sense since that forces the list of mappings to exactly match the fields available in the PDF. Recommendation: Remove the option to delete field mappings.

The attached patch implements this change.

Comments

liam morland’s picture

Title: Remove option to delete field mappings » Remove option to delete field mappings or edit PDF keys
StatusFileSize
new2.17 KB

The attached patch also removes the ability to edit PDF keys.

wizonesolutions’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)
StatusFileSize
new2.95 KB

The second patch worked as-is. The first one needed modification, and my version is attached. Both are committed.

wizonesolutions’s picture

Assigned: liam morland » Unassigned
StatusFileSize
new477 bytes

I missed something in the 7.x patch. This is a differential and committed.

  • Commit 423630c on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest authored by Liam Morland, committed by wizonesolutions:
    Issue #1508720: Don't allow deleting field mappings.
    
    
  • Commit 54d885b on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest authored by Liam Morland, committed by wizonesolutions:
    Issue #1508720: Don't allow editing PDF keys.
    
    
  • Commit bf56d32 on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest by wizonesolutions:
    Issue #1508720: Fix misapplied patch.
    
    

liam morland’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

Drupal 6 is no longer supported.