I tried running 1.0-beta2 on a dev site, and the slideshow was collapsing every time it transitioned to the third slide. I looked through the scripts and found that the 'slideToStart' value during initialization was set to a string of '0' rather than just 0. If I hard code 'slideToStart' by using:

slider.vars.slideToStart = 0;

in slider.init then the slideshow works fine and doesn't collapse on the third slide. I'm not sure where this string is coming from quite yet. I will try to track it down later. Just thought I'd let you know. Thanks for the module.

Comments

minoroffense’s picture

minoroffense commented
Title: slideToStart bug » slideToStart value set to string '0' instead of integer 0
Assigned: Unassigned » minoroffense

I'll add some typecasting when setting the variable. Working on it now and post an update once I have a fix.

minoroffense’s picture

minoroffense commented
Status: Active » Needs review

I've applied the changes. Seems to do the job. Please test and let me know.

See commit http://drupalcode.org/project/flexslider.git/commit/bef77e5

Thanks!

efarg’s picture

efarg commented
Version: 7.x-1.0-beta2 » 7.x-1.0-rc2
Assigned: minoroffense » Unassigned

Unfortunately, the described error
Undefined index: class in ais_preprocess_image() (Zeile 204 von /var/www/xxx/xxx/xxx/sites/all/modules/ais/ais.module)
steps with me also after the patch #2 further on.

MD3’s picture

MD3 commented

Just wanted to confirm efarg's (#3) comment. Using the fields version of flexslider. I get the error message for every image on the next page (aka view a page with flexslider, then view another page and get the errors). So, when my slider has 3 images, I get 3 errors. When my slider has 2 images, I get 2 images. Fresh install of 7.12.

Adaptive Image Styles (ais) 7.x-1.0

Got to this thread from your link:
#1370186-7: Notice: Undefined index: class in ais_preprocess_image() (line 204

Error is:
Notice: Undefined index: class in ais_preprocess_image() (line 204 of [Drupal Base]/sites/all/modules/ais/ais.module).

mjohnq3’s picture

mjohnq3 commented

Verifying #3 and #4: I get the same error - one error each per image. If only one image is uploaded it displays; more than one image just throws an error for each image - none of the images are displayed.

AIS 7.x-1.0, Flexslider 7.x-1.0-rc2, clean install of Drupal 7.12.

minoroffense’s picture

minoroffense commented
Assigned: Unassigned » spotzero
Status: Needs review » Postponed (maintainer needs more info)

Alright I'm a little confused. Is this an issue with Flex Slider or AIS? If the error message you're getting is Undefined index: class in ais_preprocess_image() then this should be in the AIS issue queue.

Is anyone getting an error from Flex Slider?

Can you disable AIS and see if Flex Slider works?

minoroffense’s picture

minoroffense commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

I just noticed we've gone off topic for this issue. If you get an error with Flex Slider alone, please open a new issue describing the error.

But the original problem of the slideToStart value should be fixed.

Thanks!

malaysian.selangor’s picture

malaysian.selangor commented
Title: slideToStart value set to string '0' instead of integer 0 » The block collapse after first images
Component: Code » Views Slideshow Integration
Assigned: spotzero » Unassigned
Status: Closed (fixed) » Active

Hi, I am using flexslider for view slideshow and I am using a block.
The flexslider collapsed after the first image.
Thanks for reply

marcoka’s picture

marcoka commented

it works fine here with the latest dev. i have two images in the slide, everything is fine, so i can not confirm this

socalgmc’s picture

socalgmc commented

I'm using Flex Slider directly with Image fields, and the first(default) slide collapses. Occasionally it will flash across the screen before collapsing. Only until the second slide loads will the fist slide become available.

Same problem with both 7.x-1.0-rc2 and dev versions. I'm using a clean install of the latest Drupal 7.

Thanks.

minoroffense’s picture

minoroffense commented
Title: The block collapse after first images » slideToStart value set to string '0' instead of integer 0
Status: Active » Closed (fixed)

This issue is related to the slideToStart value was set as a string instead of int. That has been resolved. If you have a new issue not related to this one please open a new issue.

Thanks

  • Commit bef77e5 on 7.x-1.x, youtube, 8.x-2.x, startslide by minorOffense: 
    Fix for issue [#1509102] Added typecasting on saved values for option...