The generated query is not checking for active users, this is critical.

Find attached in the next comment

CommentFileSizeAuthor
#15 privatemsg-check_if_active-1509436-15.patch1.03 KBadnasa
#12 privatemsg-check_active-1509436-12.patch1.03 KBadnasa
#7 privatemsg-check_active-1509436-7.patch1.15 KBpaolomainardi
#5 privatemsg-check_active-1509436-3.patch1.15 KBpaolomainardi
#3 privatemsg-check_active-1509436-2.patch1.18 KBpaolomainardi
#1 check_active-1509436.patch1.17 KBpaolomainardi

Comments

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new check_active-1509436.patch1.17 KB

Status: Needs review » Needs work

The last submitted patch, check_active-1509436.patch, failed testing.

paolomainardi’s picture

paolomainardi commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-check_active-1509436-2.patch1.18 KB

Sorry this is the correct one.

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_active-1509436-2.patch, failed testing.

paolomainardi’s picture

paolomainardi commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-check_active-1509436-3.patch1.15 KB

Sorry, i forgot to add --relative to git diff.

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_active-1509436-3.patch, failed testing.

paolomainardi’s picture

paolomainardi commented
StatusFileSize
new privatemsg-check_active-1509436-7.patch1.15 KB

Trying to use a relative path starting from module root.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_active-1509436-7.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

The patch needs to be created from the root of the *project*, not the module. Meaning, the path needs to be like a/privatemsg_roles/privatemsg_roles.module.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
adnasa’s picture

adnasa commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-check_active-1509436-12.patch1.03 KB

one more time.

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_active-1509436-12.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
Column 'uid' in field list is ambiguous query: SELECT uid FROM simpletest20230users_roles ur JOIN simpletest20230users u ON ur.uid = u.uid WHERE ur.rid = 4 AND u.status = 1 ORDER BY u.uid ASC LIMIT 0, 100

needs to be u.uid.

adnasa’s picture

adnasa commented
Status: Needs work » Needs review
StatusFileSize
new privatemsg-check_if_active-1509436-15.patch1.03 KB

thank you for the feedback,
double checked and this should be fine.

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_if_active-1509436-15.patch, failed testing.

paolomainardi’s picture

paolomainardi commented

Hi Berdir, sorry for delay, i didn't have much time. Thanks adnana for submitting the updated patch.

adnasa’s picture

adnasa commented

I've failed though :-(
I don't fully understand the test suite.
will study more before I continue submitting patches.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review

#15: privatemsg-check_if_active-1509436-15.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, privatemsg-check_if_active-1509436-15.patch, failed testing.

ptmkenny’s picture

ptmkenny commented
Status: Needs work » Closed (duplicate)

This was fixed in 7.x and is now a candidate for backport here: https://drupal.org/node/834706