Re-saving revisions shouldn't remove menu from live revision

I was having a similar issue with 7.x-2.0.

A simple fix was to add a check in og_menu_node_update:

/**
 * Implementation of hook_node_update()
 */
function og_menu_node_update($node) {
  if (og_is_group_type('node', $node->type)) {
    if(isset($node->is_current) && $node->is_current === false) {
      //To ensure compatiblity with the the revisioning module, and so that unexpected changes
      //don't happen to the current node's og_menu, we are not going to make any changes to 
      //the menu unless we are working with the current revision.
      return;
    }

The same could be applied to the equivalent hook_nodeapi function in D6.

The problem with what's going on in this function in general is, as stated by the OP, that $node->og_menu is never available, and so the resulting condition acts incorrectly. The problem with my solution is that it although it handles one situation with node revisions, it will still fail when og nodes are saved programmatically, via node_save for example.

This variable is populated in og_menu_node_prepare(), which is a hook only used for the node form. A better place for this might be the 'load' function of nodeapi, but I haven't had time to consider the consequences of implementing this and how it would affect the behavior of the form posts.

A final thought for solution would be to change the conditionals in hook_node_update. Right now it's:

if ($node->og_menu) {
//do updating
}
else {
//delete everything.. !?
}

but a safer alternative would be to do nothing if the og_menu property is not set at all, and be more explicit about what it contains:

if (isset($node->og_menu) && sizeof($node->og_menu) >= 0 ) {
//do updating
}
elseif(isset($node->og_menu) && sizeof($node->og_menu) == 0) {
//delete everything.. 
}
else {
//Do nothing, not applicable
}

Hope that helps...

took justindodge's changes and rolled them into a patch for 7.x-3.x

please check if this still happens now
#1393958: Menus are lost when using Panelizer module might have fixed this.

re-open if not.

Would this be related to the menu being deleted when creating a new draft using workbench_moderation? I'm using the 7.x-3.x version.

#6 yes.. is this happening with latest 3.x version?

I apologize, it looks like I just missed the latest version. Yes, the new version fixes it in 7. Thanks!

great to hear
leaving this open for 6.x

Possibly the same issue as in #1330550: OG Menu settings get lost on custom node_save()?

Let's fix this on 7.x first, then we can backport.

Strange, from the comments above you would think it didn't happen in 7.x... Seems like some regression was introduced somewhere.
Basically all this patch adds is this, right?

  if (($current_revision = node_load($node->nid)) && $node->vid == $current_revision->vid) {

Basically, yes. That is all it does. It doesn't catch all workflow issues. In fact, it doesn't catch what I needed for my site's specific implementation at all. However, I'm hoping it will catch other's. Maybe we could have someone test with workbench moderation?

Tried to reproduce it with core revisions and also with workbench moderation;.. Wasn't able to reproduce the issue.
Anyone have detailed instructions on how to reproduce this in D7?