Patch file supplied.

CommentFileSizeAuthor
#9 1509556-wpd_cron_expiring_zero_dated_hashes.patch.txt1.67 KBjp.stacey
#8 access-expiration-1509556-8.patch726 bytesberliner
#1 webform_protected_downloads.expiry_patch.patch1.12 KBxcession
webform_projected_downloads.expiry_patch.patch1.45 KBxcession

Comments

xcession’s picture

xcession commented
StatusFileSize
new webform_protected_downloads.expiry_patch.patch1.12 KB

My mistake, accidentally mis-named my patch file and also broke it completely :P

berliner’s picture

berliner commented

Hi xcession, thanks for your work. Can you please provide details about how the current version of the code fails?

xcession’s picture

xcession commented

At present the errors occurs when the editor chooses the "Access type": "Access expires", then enters 0 in both expiry fields.

In this situation we discovered that when a user submits the form, the 'expires' field in the database is populated with the date at which the form was submitted.

The module functions which check validity appear to be expecting the 'expires' field to be 0 or > time() but as neither is true the user is presented with the "invalid link" message.

berliner’s picture

berliner commented
Status: Needs review » Active

Thanks for reporting and fixing this. The patch has been committed to the dev branch.

I'm keeping this issue open until the patch has been ported to the 7.x-branch as well.

berliner’s picture

berliner commented
Status: Active » Fixed

patch has been ported to 7.x branch

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

abeld2’s picture

abeld2 commented
Version: 6.x-1.x-dev » 7.x-1.0-alpha2

Hello!
thanks for the patch!!!
But Cron kills the download link if both parameters set to zero.
Maybe someone can update the patch?

Drupal 7.x

Danny

berliner’s picture

berliner commented
Version: 7.x-1.0-alpha2 » 7.x-1.x-dev
Status: Closed (fixed) » Active
StatusFileSize
new access-expiration-1509556-8.patch726 bytes

Thanks for mentioning that. Could you try the attached patch and report back whether it solves the issue?

jp.stacey’s picture

jp.stacey commented
StatusFileSize
new 1509556-wpd_cron_expiring_zero_dated_hashes.patch.txt1.67 KB

Hi @berliner,

I'm working on the same codebase as @xcession, so D6 rather than D7.

Please find @xcession's patch and your cron patch combined and re-rolled against 6.x-1.0-rc3 .

berliner’s picture

berliner commented

Thanks. Just waiting for feedback, then this can go into the respective dev branches and I think it's time for new releases with the latest additions included.

abeld2’s picture

abeld2 commented

I can give a feedback at tuesday.

abeld2’s picture

abeld2 commented

It seems working, OK! Thanks!

berliner’s picture

berliner commented
Status: Active » Fixed

Committed to dev branches for 6.x and 7.x.
Thanks for reporting back.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.