The security team is transitioning away from e-mail as our primary contact medium. To facilitate this the "Report a security issue" project link should be updated to go directly to the s.d.o tracker.

CommentFileSizeAuthor
#5 1509836_5.patch907 bytesgrendzy
#1 1509836.png65.42 KBgrendzy
#1 1509836.patch724 bytesgrendzy

Comments

grendzy’s picture

Status: Active » Needs review
StatusFileSize
new724 bytes
new65.42 KB

dave reid’s picture

Status: Needs review » Needs work

How should this work for sandbox projects? We probably shouldn't show this link because sandbox projects are not synced to s.d.o since we don't have to manage them. Currently this would lead users to a page that says 'Invalid project selected.'

greggles’s picture

Status: Needs work » Reviewed & tested by the community

I confirmed that the $node object is structured the way this patch is written, that the patch applies to the tip of 6.x-3.x and that no syntax errors are introduced. Seems rtbc to me.

greggles’s picture

Status: Reviewed & tested by the community » Needs work

We should probably remove the link on sandbox projects, or replace it with a link to a page that explains that sandboxes don't get advisories. Maybe:

Sandboxes do not get security advisories

grendzy’s picture

Status: Needs work » Needs review
StatusFileSize
new907 bytes

Good catch Dave! Updated to allow for sandboxes. I think a link to the policy is better then a direct link to the public queue. While it's useful for users to report problems found in sandbox projects, it's also important reporters know the policy and when it's OK to make a public report.

greggles’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +needs drupal.org deployment

Same review process as #3.

The $node->project['sandbox'] is either a 1 or a 0.

dave reid’s picture

This can be a follow-up, but do we care about modules that don't have releases, or don't have a 1.0 release, or are marked as 'unsupported' as well? In those cases should we be linking to the policy page as well? It requires more logic but it also avoids unnecessary work for the security team.

dave reid’s picture

+++ b/drupalorg_project/drupalorg_project.moduleundefined
@@ -482,7 +482,12 @@ function drupalorg_project_project_page_link_alter(&$links, $node) {
+    $links['development']['links']['report_security_issue'] = l(t('Sandbox security policy'), 'security-advisory-policy');

Should this link to the specific node in case its alias changes?

drumm’s picture

Status: Reviewed & tested by the community » Fixed

Committed.

dave reid’s picture

Should we leave this open for investigating the follow-ups?

drumm’s picture

This issue is fixed enough, I think new issue(s) would be best.

drumm’s picture

Issue tags: -needs drupal.org deployment

Deployed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0b943c3 on 6.x-3.x, 7.x-3.x-dev authored by grendzy, committed by drumm:
    [#1509836] Change "Report a security issue" link to security.drupal.org