The security team is transitioning away from e-mail as our primary contact medium. To facilitate this the "Report a security issue" project link should be updated to go directly to the s.d.o tracker.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 1509836_5.patch | 907 bytes | grendzy |
| #1 | 1509836.png | 65.42 KB | grendzy |
| #1 | 1509836.patch | 724 bytes | grendzy |
Comments
Comment #1
grendzy commentedComment #2
dave reidHow should this work for sandbox projects? We probably shouldn't show this link because sandbox projects are not synced to s.d.o since we don't have to manage them. Currently this would lead users to a page that says 'Invalid project selected.'
Comment #3
gregglesI confirmed that the $node object is structured the way this patch is written, that the patch applies to the tip of 6.x-3.x and that no syntax errors are introduced. Seems rtbc to me.
Comment #4
gregglesWe should probably remove the link on sandbox projects, or replace it with a link to a page that explains that sandboxes don't get advisories. Maybe:
Sandboxes do not get security advisories
Comment #5
grendzy commentedGood catch Dave! Updated to allow for sandboxes. I think a link to the policy is better then a direct link to the public queue. While it's useful for users to report problems found in sandbox projects, it's also important reporters know the policy and when it's OK to make a public report.
Comment #6
gregglesSame review process as #3.
The $node->project['sandbox'] is either a 1 or a 0.
Comment #7
dave reidThis can be a follow-up, but do we care about modules that don't have releases, or don't have a 1.0 release, or are marked as 'unsupported' as well? In those cases should we be linking to the policy page as well? It requires more logic but it also avoids unnecessary work for the security team.
Comment #8
dave reidShould this link to the specific node in case its alias changes?
Comment #9
drummCommitted.
Comment #10
dave reidShould we leave this open for investigating the follow-ups?
Comment #11
drummThis issue is fixed enough, I think new issue(s) would be best.
Comment #12
drummDeployed