It would be good to move the UI to a separate module, like Views, as much of this could be automated or used via drush which lessens the code needed to be loaded in production. That would also allow us to put other dependencies that would be nice on the UI that the core functionality does not need like using Views and VBO for the UI.

CommentFileSizeAuthor
#6 1510098.config-ui.6.patch8.64 KBdagmar

Comments

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Status: Active » Closed (won't fix)

There is no need for this this, since all of the UI is contained in configuration.admin.inc and that file is only loaded on the menu paths that need it (hook_menu takes care of it automatically).

dragonwize’s picture

dragonwize commented
Status: Closed (won't fix) » Active

This is still on the board for discussion. The current UI is extremely lacking and could benefit a lot from use of other modules like Views, VBO, and others that are not needed for the core functionality and so should not be dependencies to the main module.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented

Moving the UI to a separate module will not fix the UI. Introducing a dependency on Views is not a big issue, in my mind, as most sites use Views anyways. Then, if views is already a dependency, then you're in a position where you can just use VBO if it's available (and don't if it's not available)

If the UI is in a separate file (as it is now), and is only loaded by hook_menu (as it is now), then we don't need a separate UI module. In fact, having a separate UI module could cause some minor performance issues, as it will be one extra item in the module list, and will cause extra function_exists calls for hook invocations.

I won't change the status back, but let it be known that I think this is a bad idea.

lucascaro’s picture

lucascaro commented

My 2 cents:

Ideally the configuration module will be an API for other modules (like features) or be used for installation profiles or drush and therefore an UI will not be needed for those use cases.

Also, ideally, in the future, the configuration module could have a better / heavier ui.

Having that in mind, I wouldn't discard the possibility of separating the UI from the main functionality, even if we keep this on hold for now, given that we keep the UI in separate files.

For now, the only way to use the module is through the UI, so it wouldn't make sense yet. But again, when we get the drush integration done, and if the UI grows we should get back to this issue.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev

This will be implemented in the 2.x during next week.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Active » Needs review
StatusFileSize
new 1510098.config-ui.6.patch8.64 KB

Here is the new UI for the new API. I will commit this to have something to start working @GDrupal

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
commented
Status: Needs review » Fixed

Committed #6 without the trailing spaces and with extra lines at the end of the files. e55633a

The UI is incomplete now, but we are going to use other issues to complete it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.