I have padding and margins setup for images in my forum posts and comments. This makes Smiley images look very strange indeed.

Can we have the option of adding a class to Smiley images?

CommentFileSizeAuthor
#9 smiley.module.txt4.45 KBsamgreco
#7 smiley.admin_.inc_.txt8.96 KBsamgreco

Comments

fizk’s picture

Do you want to add a class by overriding a theme function or by typing it in on the administration settings pages?

samgreco’s picture

Seems like having a choice in the admin settings would be a good idea.

samgreco’s picture

Any further thoughts on this?

fizk’s picture

Status: Active » Fixed

Fixed. Try using the latest 7.x dev release in 24 hours and let me know if it works for you.

samgreco’s picture

Doesn't seem to be working. I get the selection in the config form, but not getting the class in the rendered output. Nothing is different.

fizk’s picture

Can you attach the smiley.admin.inc file, I want to double check that you have the right version.

samgreco’s picture

StatusFileSize
new8.96 KB

Sure.

fizk’s picture

Thanks, can you also attach smiley.module.

What did you put into the "CSS class to add to smiley images" field?

samgreco’s picture

StatusFileSize
new4.45 KB

I just added the word smiley. Did I misunderstand how it works?

fizk’s picture

Can you try disabling the module, then re-enabling the module? Also try clearing the cache.

samgreco’s picture

Sorry tried both and no change.

fizk’s picture

Assuming that you tested this by creating a new node and adding a smiley to it and then looking for the class attached to the smiley img tag, I don't know why it's not working for you and I can't reproduce this.

samgreco’s picture

Actually I didn't create a new node. I will try that and reply.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.