@Jeff Burnz added this to Genesis last year. Just a simple way to add fieldsets to the advanced form. I just ported it to D8.

It's definitely related to #504962: Provide a compound form element with accessible labels

CommentFileSizeAuthor
#13 Screen Shot 2013-03-28 at 5.38.41 PM.png80.92 KBmgifford
#6 Advanced_Search_Fieldsets-6.patch2.58 KBmgifford
#3 Screen Shot 2012-06-16 at 12.57.22 PM.png58.06 KBbowersox
Advanced_Search_Fieldsets-1.patch2.51 KBmgifford

Comments

Everett Zufelt’s picture

Everett Zufelt commented

Can you please provide a description of the problem (perhaps with example markup) tha your patch attempts to solve?

mgifford’s picture

mgifford
he/him
Primary language English
commented

This is following from @Jeff Burnz's code in Genesis where he added fieldsets to the advanced search form.

It could well be that we've got a solution for this in Core without it. The checkboxes are certainly one place where we should expect to see core be able to deliver.

Jeff also grouped keyword fields together.

bowersox’s picture

bowersox commented
StatusFileSize
new Screen Shot 2012-06-16 at 12.57.22 PM.png58.06 KB

The only place that needs a fieldset is the group of checkboxes called "Only of the type(s)". Screenshot attached showing where this appears.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Active » Needs review

This should have been checked by the bot.

Status: Needs review » Needs work

The last submitted patch, Advanced_Search_Fieldsets-1.patch, failed testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new Advanced_Search_Fieldsets-6.patch2.58 KB

Just a re-roll.

mgifford’s picture

mgifford
he/him
Primary language English
commented

#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +a11ySprint

seems good.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: -Accessibility, -a11ySprint

#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented

#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +Accessibility, +a11ySprint

#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.

mgifford’s picture

mgifford
he/him
Primary language English
commented

I'd just like to add that this one is totally trivial to test on SimplyTest.me.

mgifford’s picture

mgifford
he/him
Primary language English
commented
StatusFileSize
new Screen Shot 2013-03-28 at 5.38.41 PM.png80.92 KB

Yup. They work:

Test that fieldsets still work with simplytest.me

That's highlighting with the WAVE Toolbar too. This patch just addresses the fieldsets.

Someone else has to review the code.

jessebeach’s picture

jessebeach commented
Status: Needs review » Reviewed & tested by the community

Code looks good. It's just a change to introduce fieldsets into the HTML and it's done well. Setting to RTBC.

mgifford’s picture

mgifford
he/him
Primary language English
commented

Thanks Jesse!

xjm’s picture

xjm
she/her
Primary language English
commented

#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 288619 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.