On behalf of a client, I need to backport the features integration to Drupal 6 to keep the project deployable.

Patch coming on comment 1.

CommentFileSizeAuthor
#8 features_integration-1511910-8.patch28.98 KBdeciphered
#7 features_integration-1511910-7.patch17.68 KBdeciphered
#6 features_integration-1511910-6.patch29.12 KBdeciphered
#3 features_integration-1511910-3.patch27.57 KBdeciphered
#1 features_integration-1511910-1.patch16.06 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new features_integration-1511910-1.patch16.06 KB

I have no doubts that this patch is not complete as I have only partially tested it, but this is definitely and I will continue to work on the patch until my itch is scratched.

Cheers,
Deciphered.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

While I'd hate to disrupt the d6 version with what is, in fact, a huge change, this makes sense and should go in when it's tested.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new features_integration-1511910-3.patch27.57 KB

Updated patch that actually works - Accidentally missed some files in the last one.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Does Features in D6 have the same bug related to failing to load custom feature files?

That is, this line doesn't actually work: 'default_file' => FEATURES_DEFAULTS_CUSTOM,.

See domain_features_load(), which is a workaround for that.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Needs work

Given that I did a straight backport of the D7 version, there's a good chance I backported that as well (I even backported the issue about reverting as I'd prefer them to be as similar as possible), thanks for the heads up though, I check that out today.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new features_integration-1511910-6.patch29.12 KB

Updated patch as a couple of functions where missing.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new features_integration-1511910-7.patch17.68 KB

Updated patch to removed destructive rebuild behaviour.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new features_integration-1511910-8.patch28.98 KB

Updated patch again, forgot to 'git add' the additional files.

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

Drupal 6 in End of Life and no longer supported. We encourage you to upgrade to a supported version of Drupal. For more information, see https://www.drupal.org/upgrade.

//www.flaticon.com/free-icons/thank-you Thank you for your contribution! Your continued support of this project makes other volunteer contributions more sustainable.
There are multiple ways to show appreciation for the work contributed to this project, including:
  • Triaging issues and adding more context to existing issues.
  • Writing documentation or patches for this project.