Drupal 5.x support + Multiple vocabulary support
pvasener - June 12, 2007 - 13:58
| Project: | Taxonews |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
I found this module very interesting for my site but I needed Drupal 5.x and multiple vocabulary support. This was simple as hell to hack so here is the result (to be tested of course...)
| Attachment | Size |
|---|---|
| taxonews-5.x-1.0.tar_.gz | 12.36 KB |
#1
Hi, thanks for your efforts.
This could go into the module, but you need to do some changes first:
Beyond this, I'm afraid that allowing multiple vocabularies to be selected will create massive quantities of blocks: maybe an additional selection/filtering mechanism in the settings form would be in order, to avoid swamping the block list.
How about a tab on the settings form, to allow a first level of interactive block selection (AJAX ?). admin/block would then only be applied to the blocks allowed from this level.
#2
Applying branch change
#3
Thanks for this 5.x initial release. Here is my patch to support multiple vocabularies. This patch also corrects a bug which prevents the saving of the vocabulary settings (extra quotes).
Concerning your worries about massive number of blocks, it indeed depends on the number of terms involved in the vocabularies not on the number of vocabularies itself. So, I don't think it is relevant. However, I think your suggestion for a tab in the settings form would be interesting to develop.
#4
Thanks for spotting the typo in the settings, and for the patch.
I made some changes to it, and the modified version is attached here:
But it still needs another change: currently, the
Taxonews::getTerms()method invokesdb_queryin a loop, which is not recommended. It would probably be better to generate a single query for all vocabularies and loop on its results than to generate as many queries as there are vocabularies. Can you fix this ? After that we can benchmark the two approaches just to be sure and commit the patch.A small patch to the .mo and .po files will be needed too, since some wording is changed by this patch.
#5
This has been included in the Drupal 6 branch committed today.
But would still welcome the performance improvement.
#6