Whilst boilerplate is great in some situations, we'd prefer to have the option to use our own normalise/reset stylesheets.
We love Sasson, especially the fact that (unlike other similar themes) it takes a very unobtrusive, take it, or leave it, approach to it's features. However, the forced use of boilerplate seems to be one of the few areas where it creeps into interfering with our day to day development approach.
Comments
Comment #1
tsi commentedYou can override it with you own version of boilerplate.css and call it from your subtheme's .info file :
styles[styles/boilerplate.css][options][media] = allComment #2
mint5auce commentedThanks, there are a few workarounds, but they're not ideal - for a start, it's confusing for the next person who works on the project.
My real point is, Sasson seems to allow everything else to be turned off, or customised (fonts, responsive etc), why not reset style sheets too? There are, after all, a number of equally valid approaches to reset style sheets/
Comment #3
tsi commentedTrue, we'll think about the options we have here for a while and see what we can come up with.
This basically means calling the normalize stylesheet from template.php wrapped in a
if (theme_get_setting('sasson_normalize'))which defaults to true.I guess it makes sense.
The only other thing to consider is an idea we had to put all the normalize thing into a sass mixins, discussed here : #1345448: HTML5 boilerplate values into settings
Comment #4
mint5auce commentedGreat, thanks for the quick response.
Regarding #1345448 I'm not a great fan of moving too many values into the admin settings file, we tend to keep those in the css/scss file and as a result, under source control. But as before, as long as it's a take it, or leave it, approach I don't see the harm.
Comment #5
tsi commentedNobody is talking about putting that into the theme settings UI, but a sass file with variables you can re-set on your sub-theme.
Anyway, the issue here is about making that optional, would you replace 'optional' with 'configurable' ?
What you're after is a different css normalize/reset ? or a way to configure the boilerplate's values ?
Comment #6
mint5auce commentedI'm after the ability to use a different css normalize/reset stylesheet.
Comment #7
erutan commentedI like the @import approach too - it's simple, in the main SASS file, and people can @import their own preferred reset/typo stylesheets if they wish.
On a broader note, while I understand the appeal of having settings in the admin UI in Drupal themes, a lot of the time it seems to make more sense to have some commented out options/defaults in the actual SASS/CSS file itself.
Comment #8
tsi commentedI thought about it again, and I really think the approach from #1 is the one that makes more sense. not perfect but nothing is.
We don't really need this as another checkbox in theme settings and calling it as an @import will make you override the whole sasson.scss just to get rid of that line.
Marking as won't fix but always open for discussion :)
Comment #9
erutan commentedThere's a lot of great work with sass/compass that is easily extensible to people's preferences - perhaps with the aim of making subthemes with different framework/reset choices cleaner in v3.x (as it would break current layouts) boilerplate could be taken out of the core theme and added as an @imported aspect of the default subtheme. As is someone would have to include steps 1 and 2 in a compass subtheme that went a different direction, and I'm not sure that boilerplate is integral to the theme like compass functionality etc.
Comment #10
tsi commentedActually, compass is a bad example as the php port of compass is in much worse condition. I would take compass out of Sasson much before I'd take the h5bp normalize out.
I agree, though, that it won't be very elegant for a contrib sub-theme to include a boilerplate file just to get rid of boilerplate.
ok, so let's make it optional but cooler, we'll have the option to choose between normalize.css to reset.css, what say you ?
Comment #11
erutan commentedHow would you implement it?
Comment #12
tsi commentedI think a radio button in theme settings, that will switch an @import line with a token, something like :
@import "[reset]";The two options I have in mind are compass reset (Meyer's) vs h5bp normalize.
this will allow you to set it both in theme settings and in code.
Comment #13
erutan commentedThat sounds good to me. :)
Comment #14
tsi commentedDone.
Choose between normalize VS reset VS none
http://drupal.org/commitlog/commit/31168/f34239d3a7a13c4bbe7015a48f62519...