The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The .make file adfs_standard.make contains a reference to the feature_wysiwyg project which also contains a .make file feature_wysiwyg.make.
Using Drush 4.5 + Drush Make the command drush make adfs_standard.make test detects, reads and executes the feature_wysiwyg.make file as expected.
Using Drush 5.0 Make however, the same command doesn't even create the test directory to begin with: it silently halts when it detects the new make file.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | drush-make-1512128-02.patch | 1.46 KB | jhedstrom |
Comments
Comment #1
jhedstromThe issue wasn't that it was aborting, but that errors were thrown during processing, and thus the post command hook that moves the build into place is never run.
The attached patch highlights this failure in a test (if you just update the test, and not the fix). Note that this fix won't work on the make file referenced in the opening post, because it simply runs forever (continually downloading the itself).
I searched through the git history, trying to figure out what DrushMakeProject::$overwrite was intended to do, but didn't find anything. Setting it to always be TRUE doesn't break any existing tests, but I'm a bit worried about always overwriting existing directories.
Comment #2
jhedstromForgot to attach the patch.
Comment #3
moshe weitzman commentedSeems like overwrite was introduced at http://drupal.org/node/1134326. I didn't investigate,
Comment #4
jhedstromI've committed this patch for now, since it has all the tests passing. I added a TODO so we can circle back and use some sort of merge strategy rather than simply overwriting duplicated projects.