Following-up from #1320648: Meta: start converting existing core classes to PSR-0 [policy, no patch] and as agreed in #1290658: Move all module-provided classes to PHP namespaces (PSR-0 or similar), and autoload them without the registry [policy, no patch], we can now start converting module-provided classes to the PSR-0 standard.

Subtasks (done):

Once we're through, #1541674: Remove the registry should pass.

Comments

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Add comment and taxonomy issues here as well.

We missed PagerDefault and TableSort so far which live in /includes but are always included. To keep track of them, maybe add them to this issue as well even though this is about modules? Or create a meta-meta "move everything to PSR-0/kill the registry" issue and add them directly there?

Other than than, I think there aren't many classes left except of the tests of course (and the base test classes in Simpletest itself). But I think it makes sense to wait with them until we have support for PSR-0 test classes and a first one commited, which is hopefully happening soon in the tracker issue. Then we can either create a number of issues or maybe even try to script it, as it should in theory be very simple to do and then we could do it in a single patch. It's going to break every patch in the issue that does something with tests anyway. Maybe combine it with the t() removal so that there is only a single time where we break everything?

catch’s picture

I'm happy to try to schedule patches like moving tests around / removing t() from assertions etc.

catch’s picture

Issue summary: View changes

Add comment and taxonomy issues

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

find . -name "*.info" | xargs grep "files"  | grep -v .test
./core/modules/comment/comment.info:files[] = comment.entity.inc
./core/modules/field/field.info:files[] = field.module
./core/modules/field/field.info:files[] = field.attach.inc
./core/modules/entity/entity.info:files[] = entity.class.inc
./core/modules/entity/entity.info:files[] = entity.query.inc
./core/modules/entity/entity.info:files[] = entity.controller.inc
./core/modules/taxonomy/taxonomy.info:files[] = taxonomy.entity.inc
./core/modules/node/node.info:files[] = node.module
./core/modules/user/user.info:files[] = user.entity.inc

Those field.module files contain some exception classes, opened #1542682: Convert exception classes in field.module to PSR-0. The other files are covered by the existing issues.

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Found another exception in includes/update.inc, opened #1545068: Convert Exception in update.inc to PSR-0.

berdir’s picture

Issue summary: View changes

Updated issue summary.

berdir’s picture

Issue summary: View changes

Updated issue summary.

aspilicious’s picture

Issue summary: View changes

Added issue

aspilicious’s picture

Issue summary: View changes

Added aggregator tests

aspilicious’s picture

Issue summary: View changes

Added block tests

aspilicious’s picture

Issue summary: View changes

Added book tests

aspilicious’s picture

Issue summary: View changes

Added color tests

Tor Arne Thune’s picture

Issue summary: View changes

Updated issue summary.

aspilicious’s picture

Issue summary: View changes

Added couple more test issues

aspilicious’s picture

Issue summary: View changes

Added dblog tests

aspilicious’s picture

Issue summary: View changes

Addded entity tests

aspilicious’s picture

Issue summary: View changes

fixed link

aspilicious’s picture

Issue summary: View changes

Added 5 more test issues

aspilicious’s picture

Issue summary: View changes

Added field tests

aspilicious’s picture

Issue summary: View changes

Added locale, language and menu tests

aspilicious’s picture

Issue summary: View changes

Added node and openid tests

aspilicious’s picture

Issue summary: View changes

Added path tests

aspilicious’s picture

Issue summary: View changes

Added poll and php tests

aspilicious’s picture

Issue summary: View changes

Added rdf tests

aspilicious’s picture

Issue summary: View changes

Added lots of test issues

aspilicious’s picture

Issue summary: View changes

Added search

aspilicious’s picture

Issue summary: View changes

Added system tests

aspilicious’s picture

Issue summary: View changes

Added a field entity controller issue

aspilicious’s picture

Issue summary: View changes

Added shortcut

aspilicious’s picture

We have issues for everything now, lets review and patch!

aspilicious’s picture

Issue summary: View changes

Added profiiles test issue

aspilicious’s picture

Issue summary: View changes

Update

aspilicious’s picture

Issue summary: View changes

Added statistics

berdir’s picture

Issue summary: View changes

Updated issue summary.

aspilicious’s picture

Issue summary: View changes

Splitted done and todo issues

aspilicious’s picture

Issue summary: View changes

Forgot tablesort

aspilicious’s picture

Issue summary: View changes

two done!

aspilicious’s picture

Issue summary: View changes

Profile is done

aspilicious’s picture

Issue summary: View changes

Config fixed

aspilicious’s picture

Issue summary: View changes

Some more issues done

aspilicious’s picture

Issue summary: View changes

Moved tablesort

aspilicious’s picture

Issue summary: View changes

Added issue

aspilicious’s picture

Issue summary: View changes

Updated summary

aspilicious’s picture

Issue summary: View changes

Update

berdir’s picture

Status: Active » Fixed

Ok, I'm marking this as fixed, the only remaining part is #1592632: Merge List field types into Options module which is already a major task on it's own.

Thanks everyone who worked on this!

I'm als going to set the remove registry issue to major and mark it postponed on the list issue and probably also until views/ctools/... is ready for PSR-0 (how far is that process?), so that it's not included in the threshold.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

All tasks done.