Hooks based on TASK_NAME should handle task names with dashes in them.

Patch attached

Working patch, sorry bout that

you can just define your multi-word tasks using underscores, and Drush happily deals with that.

We should also clean up provision and everywhere else to use hyphens for Drush commands.

This sounds like a contradictory recommendation. Are you recommending I use underscores in my drush commands while saying provision should use hyphens? Also, "provision-" is automatically appended to my hosting task name to come up with the appropriate drush command, for my project, the drush command would have to be "drush provision-devshop_sync which, to me, is going backwards.

hostmaster doesn't string replace hyphens to underscores when looking up a hook. It should. Form API does the same thing, as do other subsystems of Drupal.

Functions must use underscores. Template files, form IDs both do replacement one way or another. Drush commands use hyphens. This one line change would make it work much like the rest of Drupal does.

I COULD make all of my drush commands use underscores, but then, because

Hosting.module does not convert hyphens for underscores when looking for its hooks. That to me is a bug.

Due to the architecture of hosting.module, in this code, "provision-$task" MUST be a valid drush command. If the drush command is more than one word, it should be hyphenated, which breaks hook lookups.

-  $func = 'hosting_task_' . $task . '_form';
+  $func = 'hosting_task_' . str_replace('-', '_', $task) . '_form';
 if (function_exists($func)) {
     $form['parameters'] += $func($node);
   }

Patch attached for 1.9. I need to start here, If approved for 1.9 I'll make it for 2.x and 1.x.

I still think this is a valid backport. What did you mean by:

change provision to use hyphens when calling drush

I didn't see any changes needed in provision, but maybe thats because I haven't dug into 2.x yet.

Attached is a patch to 2.x-dev branch of hostmaster.

Changing the title to reflect the real issue.

I wonder how drupal core handles this... they switch _ to - and back again for templates, menu items, etc.

/me runs to api.drupal.org....

function node_menu() {
  //...
foreach (node_type_get_types() as $type) {
    $type_url_str = str_replace('_', '-', $type->type);
    $items['node/add/' . $type_url_str] = array(
//...

Same way as us! That's kind of funny... so I guess we are doing this "right"? I gotta admit, it does seem a bit hacky that drupal itself doesn't have a global function to convert dashes to underscores...