Closed (fixed)
Project:
Options Element
Version:
7.x-1.7
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2012 at 19:06 UTC
Updated:
22 May 2012 at 20:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
quicksketchThe settings for options are supposed to be disabled if you're using a pre-built list, since that list is being provided by code. If you want to edit the list, you can pre-fill the list by selecting a pre-built list, then changing it back to "None". Then you can edit the options but they'll no longer be provided through code.
Comment #2
liam morlandI can't change it back to None; that setting is disabled. So is "customize keys" and the other settings in the Options fieldset.
Comment #3
quicksketchOh, yep you're quite correct. I think this is Webform having this effect. Everything works fine while you're editing the component like it's intended (you can see the list and set a default, but not change the values or order), but after saving and re-editing the component things go all wrong.
Comment #4
liam morlandThanks. The attached patch solves the issue. Everything seems to work properly. I like simple solutions!
Comment #5
liam morlandComment #6
liam morlandOne problem: The first solution allows the values to be edited when a pre-built list is selected, though the edits are not saved. The attached patch, which patches Options Element instead, produces the desired behavior, but I am not clear if it has unintended side-effects. Please review.
Comment #7
liam morlandComment #8
quicksketchThanks Liam, does your latest patch in #6 replace the one in #4, or do they both need to be applied?
Comment #9
liam morlandJust #6 is needed.
Comment #10
quicksketchThanks committed to both branches.
Comment #11
liam morlandThanks. I'm not seeing the change when I do a git pull. Have you pushed it yet?
Comment #12
quicksketchSorry I hadn't pushed. Up now.