The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.If you edit your settings.php file to put in invalid information (like what would happen if you moved your install to a different host, or if the database was temporarily unavailable), where you would normally get a nice maintenance page that says "Unable to connect blah blah" you instead get:
Fatal error: Call to undefined function file_directory_path() in /Applications/MAMP/htdocs/head/includes/common.inc on line 1769
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | file_directory_path_2.patch | 1.1 KB | RobRoy |
| #4 | file_directory_path_1.patch | 710 bytes | RobRoy |
| #3 | 151394-2.patch | 1.03 KB | xqus |
| #2 | 151394.patch | 773 bytes | xqus |
Comments
Comment #1
webchickBtw, looks like this was introduced in the JS aggregation patch.
Comment #2
xqus commentedWell, here is a simple fix.
Just added the inclusion of includes/file.inc in the drupal_maintenance_theme() function.
A maybe better fix would be to change the drupal_get_js() function to take an argument to disable the JS preprocessing when the database is not available.
Comment #3
xqus commentedHere is a different approach. It adds some more checks to the drupal_get_js() function.
Comment #4
RobRoy commentedVerified that both patches fix the problem. Just depends on which one is more elegant probably as I think they'll both perform the same. I'm slightly more a fan of #3.
This is a re-roll of patch #2 with trailing spaces removed.
Comment #5
RobRoy commentedHere is a re-roll of #3 which I slightly prefer. This abides by coding standards and includes a comment to boot. Gabor, both these patches work, guess it's just up to you which you prefer.
Comment #6
gábor hojtsyOK, committed #4, as I think we are better off with including what we need then having special cases for all functions we might not have. The maintenance theme could be any complex. Thanks.
Comment #7
(not verified) commented