This is beta so I fully expect it not to be perfect. Feel free to just close the issue if you aren't ready for bug reports. I'm just mentioning them because not everyone develops with all the notices on so you might not be aware of these.

  • Strict warning: Only variables should be passed by preference in include() (line 61 of ...biolife/node.tpl.php)
  • Notice: Undefined index: noodle in drupal_theme_initalize() (line 98 of ...includes/theme.inc)
  • Notice: Trying to get propery of non-object in phptemplate_init() (line 12 of .../phptemplate.engine)
  • Notice: Trying to get property of non-object in drupal_alter() (line 997 of .../module.inc)
CommentFileSizeAuthor
#2 biolife-node-tpl-notices-1514084-02.patch850 bytesarpieb

Comments

betarobot’s picture

betarobot commented

All clear in logs on my setup, so the questions is how to see all the notices?

thx

arpieb’s picture

arpieb commented
Status: Active » Needs review
StatusFileSize
new biolife-node-tpl-notices-1514084-02.patch850 bytes

Regarding the "strict warning" message above, here is a patch to fix that in both node.tpl.php and node--news.tpl.php as the code is the same in both templates. The D7 render() only wants to be passed actual variables as it needs to modify the render array; passing the return value from a function is what's causing the error.

The other errors sound like maybe the Noodle base theme isn't enabled...?

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

@betarobot: Sorry, somehow missed this. You can look in error.log to see them. There's also a change you can make with the E_* stuff to have them show on the screen but I can't remember off the top of my head how that's done. :(

@arpieb: It's possible it wasn't enabled. I didn't realize base themes needed to be enabled. I thought they just needed to be present.

arpieb’s picture

arpieb commented

Base themes in D6 didn't have to be enabled, but if any Drupal core calls try to query active themes the base theme won't show up. I've seen sketchy behavior on D6 and D7 both if a base theme isn't installed - some things appear to work great, others not so much. Think of a theme like a module - if it's not enabled, some of the base theme functions *might not* be available to subthemes.

It might not be the cause of your problems, but if you've got Biolife installed and enabled, which means Noodle Base should be there - it's the only reason I can think of that Drupal core can't find the theme.

I know that I'm working on a very Omega-heavy project right now, and the frontend developers have got the Omega base themes enabled on all sites involved, so there might be something to it...

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented

I don't know... I only installed it out of curiosity so I don't remember if I had the base theme enabled or not. If that's the likely cause of it and no one else is having problems, I suggest just fixing the one you found to be a bug and not worrying about the others unless someone actively using the theme brings them up.

betarobot’s picture

betarobot commented

@arpieb thanks for patch! Makes sense I guess, strange enough I haven't see any notices at my dozen of setups. Will commit it with more updates around weekend, as well as to Noodle then, as it shares the same code in this case.

And @Michelle you don't have to enable the base theme in D7 (just sub theme, the rest should pick up). But hmm, @arpieb wondering about your Omega experience now.

arpieb’s picture

arpieb commented

The bug probably only shows under a couple conditions - the correct set of PHP error flags in the config and what version of PHP you're running on. It seems like one of the 5.3 versions started complaining more about the use of temp arrays generated by function calls than earlier versions (I've run into the same kind of error with other contrib modules on 5.3.x installations).

Who knows with Omega, maybe due to the heavy module integration with Delta and Omega Tools (which we're also using) it is required to be enabled...

On a side not, got BioLife dropped into a site, subthemed it, and really like the layout, features and regions. Nice job!

betarobot’s picture

betarobot commented
Status: Needs review » Closed (fixed)

@arpieb your patch again. And thanks for compliment!