Language Path Checking: external url option is wrong for LOCALE_LANGUAGE_NEGOTIATION_URL_DOMAIN case

Tested, and works as intended. Thanks!

Hi,

I'm not sure if I've configured my site in some weird manner, but I don't get this to work with this patch.

The URL protocol is not a part of $lang->domain.

I'm running on two private IP addresses but that could hardly have any impact, right?

http://192.168.0.131/node/1 (English node on Swedish site) redirects to http://192.168.0.131/192.168.0.130/wedding-logos instead of http://192.168.0.130/wedding-logos.

I had the same problem, patch dosn't work for me.

This works for me:

              // There is a matching language for this alias
              if ($alias != $current_path) {
                if (isset($lang->domain)) {
                  $options['language'] = $lang;
                  drupal_goto($alias, $options, 301);
                }
                break;
              }

Hi,
I had the same problem and I think the problem is the missing protocoll in the drupal_goto() url.
This works for me:

// There is a matching language for this alias
if ($alias != $current_path) {
  if (isset($lang->domain)) {
    global $is_https;
    $options['external'] = TRUE;
    $options['absolute'] = TRUE;
    $protocoll = $is_https ? 'https://' : 'http://';
    drupal_goto($protocoll . $lang->domain . '/' . $alias, $options, 301);
  }
  break;
}

Version: 7.x-1.5

I also have an issue with the LOCALE_LANGUAGE_NEGOTIATION_URL_DOMAIN case, but the issue is that there is no redirect.
The node has no special path, just node/2.
if node/2 is on english, he.domain.tld/node/2 does not get redirected to en.domain.tld/node/2 since the paths are both the same.
I tried fixing it but I did not get the loop's behavior and only caused a redirect loop.

I went back to fix this issue, so here is my solution:
Instead of the current loop it checks for the actual node's language, Then if the current domain and the node language's domain are different it redirects to the correct domain.
(the use of the alias is just a bonus, to reduce redirects, e.g. lang1.domain.tld/node/2 > lang2.domain.tld/node/2 > lang2.domain.tld/somepage)

The following code worked for me:

global $is_https;
$scheme = $is_https ? 'https://' : 'http://';
$options['external'] = TRUE;
drupal_goto($scheme . $lang->domain . '/' . $alias, $options, 301);

Here's another solution.

oops

corrected whitespace

Seems to be working fine with the newest release 1.5.

I would like to reopen this issue because I suspect that the patch is not complete yet.

I'm running this patch together with a patched version of the redirect module (patched with https://www.drupal.org/node/1796596#comment-9313853 ) and when I'm trying to access a non-existing page, this patch creates an infinite redirect loop because $node is NULL here.

I've added this to the if-statement in my attached patch to prevent these redirect loops.

Also, I am currently running into problems where I have nodes that are not translatable (and actually also not viewable on their own). Viewing the node causes to create an infinite loop. I adjusted my patch to check for the LANGUAGE_NONE case, in which I think we should not redirect at all.

Why does the #19 patch failed testing? It worked for me.

Applied patch #19 and works for me too! Will test this this week and post any errors

Rerolling patch to see if new tests will succeed, minor change in using globalredirect_goto() instead of drupal_goto()

Is this same as https://www.drupal.org/project/globalredirect/issues/1653194

patch #19 works for me, thanks a lot!

Patch #19 works for me too, thank you very much!

Created simple module that solve this issue for me https://github.com/parisek/custom_i18n_redirect (I prefer that instead of patching module)

This patch is based on the comment from @michaelpetri in #4

This fixes the problem when you have separate domains for languages - e.g. `mysite.se, mysite.com`

Going to http://mysite.se/node/123 where node/123 is in English will redirect to the correct alias on http://mysite.com/myalias

This works for me on a site with i18n, i18n_node, pathauto_i18n enabled (but not i18n_redirect)

Rerolled patch for #32 as it failed to apply, please review.