Closed (fixed)
Project:
Taxonomy Term Reference Tree Widget
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Apr 2012 at 10:22 UTC
Updated:
25 May 2019 at 20:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
blackice2999 commentedhmm it seems there is a problem with # in filenames here...
added new patch file
Comment #3
sharlak commentedI have tested this patch and it worked fine for me; thank you!
Comment #4
kunago commentedThere was a warning popping up about an array_flip issue. After changing the line suggested above the warning is gone.
So tested and seems to be working fine.
Comment #5
paulap commentedThx. Works.
Comment #6
Norberto Ostallo commentedWorks for me too, hope to see it committed soon.
Comment #7
creatile commentedThe patch doesn't work for me, I still have error messages
I am using drupal 7.14
The error message only appears when editing fields of content type
I also have some problems to use this module when I use this taxonomy translation mode:
Translate. Different terms will be allowed for each language and they can be translated.
With this mode the terms of different languages will appear in the tree whereas with the localize mode I only have the current language terms.
Thanks
Comment #8
Norberto Ostallo commentedThe patch seems to solve the problem when the field is required.
For not required fields it seems that the module tries to translate the empty option, generating the error.
Comment #9
KLicheR commented#7, your second problem about seeing all terms for the Translate translation mode is discussed here #1433182: Translation of the taxonomy tree (multiple translated terms inside the same vocabulary).
Comment #10
KLicheR commentedThe patch #2 work for me.
Comment #11
mikran commentedI'm also having issues with this patch and non-required fields. Required fields work fine.
Comment #12
mikran commentedThis patch fixes the issues with '#required' => FALSE elements.
Comment #13
rbosscher commentedApplied patch #2 with succes, I have no issues with te (non)required field.
Comment #14
k4v commentedpatch #12 worked for me, thanks =)
Comment #15
Frando commentedYup, #12 works and fixes the bug. Setting to RTBC.
Comment #16
FranckV commentedBrilliant ! #12 solves all my issues. When do you plan a new release including this necessary patch ?
Comment #17
weri commentedThe patch #12 works. Please commit.
Comment #18
harryzhxu commentedpatch #12 for me too
Comment #19
hiro.ifactory commentedI have tested the patch #2 and it worked fine for me; thank you!
Comment #20
eidoscomI have tested the patch #12 and it worked fine for me!
Comment #21
ilfelice commentedFWIW, patch from #12 is working here too (on a Drupal 7.21 installation).
Comment #22
dave reidThis is going to conflict with #1595358: EntityMalformedException when trying to configure settings or edit nodes. It would be good to postpone until that issue lands and then follow-up with the required changes here.
Comment #23
alex72rm commentedThe problem apparently is still there with the new version installed:
Comment #24
kubrt commentedI confirm that the issue has not been addressed in 7.x-1.10 and the patch #12 worked.
Comment #25
alex72rm commentedTo be sure to have understood, the patch works for the 1.9 version of the module, but the new version (1.10) is still with the issue unsolved?
Comment #26
mikran commentedThat's likely to be the case. I'll do a reroll later today, unless you beat me to it
Comment #27
mikran commentedHere is rerolled version.
Comment #28
alex72rm commentedIt works! Thank you very much!
Comment #29
Norberto Ostallo commentedWorks for me, too.
Comment #30
roam2345 commented+1 for patch working for me as well.
Comment #31
andrijic commentedbachbach reported and proposed feasible fix on April 2013 prior to the newest 7.x-1.10 release. I just wish I have opened this thread before making a fix myself. This is a good lesson to read bug reports prior to trying to fix it yourself :)
Comment #32
delacosta456 commentedhi
Patch #27 works for me too.
Thanks
Comment #33
fgmWorks nicely here too, on taxonomy_term_tree 7.x-1.10 and i18n 1.9.
Comment #34
ptmkenny commentedI opened a related issue for ensuring compatibility with Entity Translation as well:
#2101195: Entity Translation (Title module) compatibility
Comment #35
eidoscomPatch in #27 is working since June but is not included on las dev snapshot of the module. I think that it must be commited but perhaps is something that I'm missing for this not occur??
Thanks for the patch anyway
Comment #36
pcambraConfirming RTBC, patch works fine
Comment #37
heorhi lazarevich commentedPatch #27 works for me with Term Reference Tree 7.x-1.10 and i18n 7.x-1.10
Thanks for the patch
Comment #38
Darren Clark commentedAlso confirmed that patch #27 working correctly with Term Reference Tree 7.x-1.10
Comment #39
ItangSanjana commented#27 did the trick. Thanks ..
Comment #40
ilfelice commentedConfirming that #27 works with Term Reference Tree 7.x-1.10 and Drupal 7.24.
Would be nice to see this patch committed. ;)
Comment #41
shi99 commentedAlso confirming that patch #27 worked with Term Reference Tree 7.x.1.10
Thanks a lot.
Comment #42
Hogeboom commentedGreat, #27 saves my day! Thx.
Comment #43
jennypanighetti commentedWhen will this get rolled into dev??
Comment #44
jibus commented#27 works for me too, thanks !
Comment #45
zmove commented+1, reviewed and tested by the community. When it can be commited ?
Comment #46
Leeteq commentedYes, RTBC. - time to commit?
Comment #47
jennypanighetti commentedYes please.
Comment #48
ah_ma81 commentedThanks for the patch, it is working good.
But i have a big problem, that any (Add Content type) page have a field with Taxonomy Term Reference Tree Widget is very slow ... it takes up to 40 seconds to load.
And before i install i18n, any add content type page did take maximum 5 seconds to load.
Any help please will be appreciated.
Update
I opened new issue for slow Taxonomy Term Reference Tree Widget
Comment #49
pyry_p commented#27 Seems to work.
"// do not use entity_label() for non-term elements"
Just out of curiosity, does this mean you can inject dummy values into the tree or expand the usage otherwise?
Comment #50
fernly commentedConfirming that #27 is still doing the job.
Comment #51
jsheller commentedThanks, #27 is working!
Comment #52
Leeteq commentedComment #53
sylvaticus commentedPatch #27 working, thank you.. please commit ;-)
Comment #54
JonasVerhaert commentedThx mirkan for the patch, #27 works!
Comment #55
pacproduct commentedConfirming patch #27 works great. Thanks.
Comment #56
krishna savithraj commentedConfirming patch #27 works great. Thanks.
Comment #57
matthiasm11 commentedPatch #27 works, please commit.
Comment #58
pawlus commentedI think this isn't commited for a reason. And that reason is that when you access node's Edit > Translations, the table there will show a list of node translations along with Add translation and Edit translation options. That options all pass the same language at any given time. So for example Edit links for both French and English version will look like en/node/XX/edit. As a result the widget is passed English language even on French node edit form and it loads only English terms from a vocabulary thus making French terms inaccessible on a French node edit form. This needs to be improved before it's commited. It might be Administration Language meddling, but I don't think it's the case.
EDIT: Just checked, it's not Administration language, this is default behavior.
Comment #59
devad commented@Pawlus #58
I suppose that your issue has nothing to do with Taxonomy Term Reference Tree Widget module or patches here.
Did you check if the same links are correct without this module enabled?
Also, please check if your URL detection method is enabled at:
admin/config/regional/language/configure
Or Google something like: Drupal node translation link wrong language. There are many issues created on such topics and there can be many reasons for your problem.
I suppose that we can revert this issue to RTBC since the main target for this issue are multiple PHP notices caused by missing "vid" argument.
Comment #60
hgoto commentedThe patch #27 still applies cleanly and works well for me. +1 for RTBC.
Comment #61
marttir commentedHopping on the bandwagon here; #27 works for me.
No problems like #58 with taxonomy i18n mode set to 1 (localize).
Comment #62
Delphine Lepers commentedThe patch #27 works well for me. +1 for RTBC.
Comment #63
hansrossel commentedThe patch #27 works well for me. +1 for RTBC.
Comment #64
liam morlandUniversity of Waterloo has been running the patch in #27 for months and it is working for us. +1
Comment #65
yogeshmpawarPatch works well, looks good to me +1 for RTBC.
Comment #66
jibus commentedPlease commit this, the thread is 5 years old and has been set to RTBC last year!
Comment #67
zread commentedTested patch #27, +1
Comment #68
pifagor commentedTested patch #27
Comment #70
alex_optimComment #71
pifagor commentedComment #72
alex_optim