Make attributes optional in media input filter

+++ b/includes/media.types.incundefined
@@ -42,9 +42,8 @@ function media_file_type_info_alter(array &$info) {
-  // During preview, or when custom attribute values are needed on the displayed
-  // element, use a media icon.
-  if ($view_mode == 'media_preview' || isset($file->override)) {
+  // During preview use a media icon.
+  if ($view_mode == 'media_preview') {

What is the reason behind changing this logic? It doesn't seem related to the change in attribute handling?

@Dave

function media_token_to_markup($match, $wysiwyg = FALSE) {
    $settings = array();

  // ...................

  $attributes = (isset($tag_info['attributes']) && is_array($tag_info['attributes'])) ? $tag_info['attributes'] : array();
  $attribute_whitelist = media_variable_get('wysiwyg_allowed_attributes');
  $settings['attributes'] = array_intersect_key($attributes, array_flip($attribute_whitelist));

  // ...................

  $element = media_get_file_without_label($file, $tag_info['view_mode'], $settings);
  drupal_alter('media_token_to_markup', $element, $tag_info, $settings);
  return drupal_render($element);
}

function media_get_file_without_label($file, $view_mode, $settings = array()) {
  $file->override = $settings;
  // ...................
}

$file->override is always set for the media input, so it will always be replaced by an icon in theme_media_formatter_large_icon.

The previously patch worked as expected, so uploaded again.

#6: 1514894-6.patch queued for re-testing.

no longer applies

#8: 1514894-2.patch queued for re-testing.

Closing this issue as outdated. However, if you think this issue is still important, please let us know and we will gladly re-open it for review.
sincerely,
- the Drupal Media Team