There's an explicit call to drupal_redirect_form in workbench_moderation_moderate_form_submit that prevents additional submit handlers from getting added and called. Specifically, I would like to add submit handler after moderate_form_submit to capture additional information related to workbench_moderation_node_history.

CommentFileSizeAuthor
#1 workbench_moderation-redirect_form-1515110.patch389 byteswalkah

Comments

walkah’s picture

walkah commented
Status: Active » Needs review
StatusFileSize
new workbench_moderation-redirect_form-1515110.patch389 bytes

simple 1-line patch.

hass’s picture

hass commented

#1: workbench_moderation-redirect_form-1515110.patch queued for re-testing.

teknic’s picture

teknic commented

Is this going to be rolled in to a future release?

sunnydeveloper’s picture

sunnydeveloper commented

Any update?

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community

Please review patches you want to see in future releases of a module, so that they get in

teknic’s picture

teknic commented
Issue summary: View changes

I've reviewed this patch and have it running on two production sites currently with no negative impacts on the functionality of workbench moderation.

Johnny vd Laar’s picture

Johnny vd Laar commented

Works for me!

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

  • colan committed 15d29d6 on 7.x-1.x authored by walkah 
    Issue #1515110 by walkah: Removed call to drupal_redirect_form.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Fixed » Patch (to be ported)

Might need to be forward ported.

  • colan committed 15d29d6 on 7.x-3.x authored by walkah 
    Issue #1515110 by walkah: Removed call to drupal_redirect_form.