It appears that the nodeteaser cannot be updated once set for nodes of content-type "webform"!
I can't understand why it would be a problem either :-S

Upon submission of the webform page
hook_nodeapi() is called with the following $op's

load

prepare

validate

submit

Upon further investigation in the webform.module i wonder if that might be at fault?

function webform_update($node) simply deletes any existing version of the node and then recreates it using function webform_insert($node) - however this module then jumps out of the node process using drupal_goto('node/'. $node->nid); !

I don't think that's right as it effectively terminates any possible hook_nodeapi() calls in node_save() then!

Comments

budda’s picture

budda
Primary language English
Location Cheshire
commented
Title: Doesn't work for Webform.module nodes » Webform doesn't obey Drupal NodeAPI
Project: Node Teaser » Webform
Version: 5.x-1.1 » 5.x-1.x-dev
Status: Active » Reviewed & tested by the community

Through the user of nodeteaser.module I found that webform.module doesn't correctly work with Drupal's node system due to a naughty drupal-goto() in the hook_insert() function!

The redirection prevents node_save() from calling any other modules via the hook_nodeapi() to save their data associated with the webform node.

The simple fix is to remove the folowing line from function webform_insert($node):

drupal_goto('node/'. $node->nid);

Please don't say you need a patch to do that :)

quicksketch’s picture

quicksketch
he/him
commented
Status: Reviewed & tested by the community » Fixed

This drupal_goto() has already been removed in another issue.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)