Before commit 18234a002ad7ead157f8610498112acbab49ea91 the table rows were removed by $(this).remove();
After the commit the rows are removed by a calculated id reference derived from the package name in the module information with

          var $row = $('#' + id);
          var name = $.trim($row.text());
          $row.remove();

This can become a problem when the generated id matches something predefined.

For example, module "Field Redirection" is in package "Content", so the row to be removed is <tr id="content" ...
What actually gets removed is <div id="content" ... i.e. everything in the module list.
Since the generated tabbed list is also built under that div the result is utterly empty.

Comments

catmat’s picture

catmat commented

The actual fix should probably involve limiting the match to table rows, locally we just appended '-pkg' to the generated ids:

--- module_filter.module	2012-02-15 17:14:25.000000000 -0600
+++ module_filter.module	2012-04-04 10:59:54.000000000 -0500
@@ -199,5 +199,6 @@
 function module_filter_get_id($text) {
   $id = strtolower($text);
   $id = preg_replace('/([^a-z0-9]+)/', '-', $id);
+  if ($id != 'all' && $id != 'new')  $id .= '-pkg';
   return trim($id, '-');
 }

Exceptions for 'all' and 'new' were needed because of the way enabled_counts is constructed in module_filter.theme.inc

greenskin’s picture

greenskin commented
Status: Active » Fixed

Appended "-package" to package row ID's.
http://drupalcode.org/project/module_filter.git/commit/ecd1847e86d707c60...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.