What can I do?

This module allows to integrate Pinteres't Pin It Button in our sites.

Basically, the module fetch the image, url and description from the node and create a link for share on Pinterest.

Pinterest?

Pinterest is a social bookmarking tool used to “pin” images found around the Web into categorized collections, or boards.

Links

Works in D7

Comments

leandro713’s picture

please ensure you commit via git the files.
i cloned the project and your working directory is empty :(

soncco’s picture

Are you used the master or the 7.x-1.x?
Please check the Git instructions on http://drupal.org/project/1515360/git-instructions

leandro713’s picture

yes, Braulio, you're right, i was on master branch. my fault!
i was code sniffering and seems your code has some code style issues, like whitespaces and indentation:

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/pinit.admin.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
21 | ERROR | Whitespace found at end of line
23 | ERROR | Array indentation error, expected 4 spaces but found 6
24 | ERROR | Array indentation error, expected 4 spaces but found 6
25 | ERROR | Array indentation error, expected 4 spaces but found 6
--------------------------------------------------------------------------------

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/pinit.class.inc
--------------------------------------------------------------------------------
FOUND 15 ERROR(S) AFFECTING 14 LINE(S)
--------------------------------------------------------------------------------
160 | ERROR | Whitespace found at end of line
161 | ERROR | Missing function doc comment
162 | ERROR | Whitespace found at end of line
165 | ERROR | Whitespace found at end of line
168 | ERROR | Whitespace found at end of line
173 | ERROR | Whitespace found at end of line
175 | ERROR | Array indentation error, expected 6 spaces but found 8
176 | ERROR | Array indentation error, expected 6 spaces but found 8
177 | ERROR | Array indentation error, expected 6 spaces but found 8
177 | ERROR | If the line declaring an array spans longer than 80 characters,
| | each element should be broken into its own line
178 | ERROR | Array indentation error, expected 6 spaces but found 8
179 | ERROR | Array indentation error, expected 6 spaces but found 8
180 | ERROR | Whitespace found at end of line
181 | ERROR | Whitespace found at end of line
353 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/pinit.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
41 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------
soncco’s picture

Thank you! Standards done!

patrickd’s picture

Welcome!

We do really need more hands in the application queue and highly recommend to get a review bonus so we will(/can) come back to your application sooner.

soncco’s picture

Hi patrickd, I'm actually reviewing some applications :).

patrickd’s picture

Status: Needs review » Closed (duplicate)

That's great ;-)

but...

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/1515382
Project 2: https://drupal.org/node/1442482

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

Sorry

soncco’s picture

Don't worry patrickd, Thank you for your help. I'll be here waiting for approve my another application. Meanwhile I'm reviewing some applications :).

avpaderno’s picture

Title: PinIt » [D7] PinIt
Issue summary: View changes
Related issues: +#1442482: [D7] Slide Ad