As noted in the module's description, there is not currently a method to connect the Webform Submission ID and the VoIP Call ID. This would be useful in displaying call information with the submission results (i.e. Call duration, phone number, etc). This patch aims to fix the problem by the following:

- Create a database table voipwebform_submissions with fields sid and cid.
- On VoIP Webform submission, we simple insert the two values.

This patch does not address output of the connected data on the submission results page. It appears that we might need to request a hook from the webform module to push this data into it, but collecting the data to begin with is good start.

CommentFileSizeAuthor
#3 voipwebform-link-sid-and-cid-1515502-3.patch1.17 KBmatt@antinomia
#1 voipwebform-link-sid-and-cid-1515502.patch1.46 KBmatt@antinomia

Comments

matt@antinomia’s picture

matt@antinomia commented
StatusFileSize
new voipwebform-link-sid-and-cid-1515502.patch1.46 KB

Patch

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented

There are some other tickets in here with similar patches (adding new tables) but you only need to run drupal_install_schema('voipwebform') to install all tables in hook_schema. Just take those lines out and leave the new hook_schema definitions.

matt@antinomia’s picture

matt@antinomia commented
StatusFileSize
new voipwebform-link-sid-and-cid-1515502-3.patch1.17 KB

Check. Here's the new one. It's testing fine for me. I'm going to go ahead and commit it, or at least try (first Git commit). :)

matt@antinomia’s picture

matt@antinomia commented
Status: Needs review » Fixed

Well, that was easy!

http://drupalcode.org/project/voipwebform.git/commit/609730f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.