Strict warning: Only variables should be passed by reference in content_features_rebuild() [#1515878]

Comment	File	Size	Author
#5	features-1515878-5-strict-warning.patch	1.45 KB	mikeytown2

#1	features-1515878-1-strict-warning.patch	1.47 KB	mikeytown2

File	Size
features-1515878-1-strict-warning.patch	1.47 KB

Comment #2

hefox CreditAttribution: hefox commented 5 April 2012 at 04:13

Status:

Needs review

» Needs work

Don't have strict enabed

+++ b/includes/features.content.inc
@@ -148,11 +148,13 @@ function content_features_rebuild($module) {
+      $existing_instance = array_shift($read);

Would reset be better here?

+++ b/includes/features.content.inc
@@ -148,11 +148,13 @@ function content_features_rebuild($module) {
+      unset($read);

Is this unset really worth it? If continue with the array_shift instead of reset, it's just an empty array leftover. It's fairly non-standard to do, tmk.

+++ b/includes/features.content.inc
@@ -167,7 +169,7 @@ function content_features_rebuild($module) {
         // Summary: content_field_instance_create() will fall back to prior
-        // instance values for weight, label, desc if not set. 
+        // instance values for weight, label, desc if not set.

Unrelated white space

Log in or register to post comments

Comment #3

mikeytown2 CreditAttribution: mikeytown2 commented 5 April 2012 at 18:57

White space fixes happen automatically by my editor.

If an empty array is all that is left (array that has one value), why not access the existing instance via the known key; or are the keys unknown (why not use key() then)? I did an unset because we don't use the variable after extracting what we want from it; I didn't know the size of whats left thus the use of unset to make sure memory usage doesn't get out of control.

Use this on your dev environment.

  // Report all php errors.
  error_reporting(-1);

Log in or register to post comments

Comment #4

hefox CreditAttribution: hefox commented 5 April 2012 at 19:30

Need to fix the whitespace in features, but coding standard issues should generally not be part of an unrelated patch.

The function should only be returning an array with one item given the parameters sent to it (there should only be one field per field_name/type), so just need to get that one element in that array, thus array_shift leaves an empty array when it's done.