“IE6 and earlier require a hacky method to center divs”

Ha, that was IE5.5!
patch following...

CommentFileSizeAuthor
#1 outdated-ie-hack-1515912-1.patch2.17 KBechoz

Comments

echoz’s picture

echoz commented
Status: Active » Needs review
StatusFileSize
new outdated-ie-hack-1515912-1.patch2.17 KB

Here's a patch removing this ie5.5 hack from 4 files. Somebody tell me I'm not crazy.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

According to http://drupalcode.org/project/zen.git/blame/refs/heads/5.x-1.x:/ie.css its an IE5 and IE6 quirks mode behavior.

Hmm… since we shouldn't be triggering quirks mode in IE6…

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: outdated ie hack » Remove outdated IE hack
Status: Needs review » Fixed

Fixed!

Thanks for the fact check. :-)

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

You missed a chunk in STARTERKIT/css/layouts/fixed-width-rtl.css. :-) Fixed now too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.