This is a drupal 7 theme with the following features:

3-column simple theme initially developed for automobiles site.
8 Regions for different blocks/content of the site.
Clean css, Html.
Jquery banner configurable on homepage only.
Standard drupal 7 theme with proper commenting and clean code.
Clean on all standard browsers and versions.

Project page: https://drupal.org/sandbox/muhammad.tanweer/1079224
Git: git clone http://git.drupal.org/sandbox/muhammad.tanweer/1079224.git automobile
Webgit: http://drupalcode.org/sandbox/muhammad.tanweer/1079224.git

CommentFileSizeAuthor
#6 footer_spacing.png12.25 KBzymphonies-dev
#6 article.png44.74 KBzymphonies-dev
#6 footer.png4.73 KBzymphonies-dev
#6 content_wrapper.png45.36 KBzymphonies-dev

Comments

patrickd’s picture

patrickd commented
Status: Needs review » Needs work

Welcome!

There's no code to review, you've only done an initial commit yet.
Please read how to use GIT on drupal.org: https://drupal.org/documentation/git

You are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

regards

2012AudiA6’s picture

2012AudiA6 commented

Thanks for the tip

muhammad.tanweer’s picture

muhammad.tanweer commented
Status: Needs work » Needs review

Hello Patrickd,

Thanks for the useful instructions.
I have now added the code to git repository. Please review the code.

Thanks

jleiva’s picture

jleiva commented
Status: Needs review » Needs work

Hi muhammad.tanweer, my manual review so far:

  • You are working in the "master" branch in git. For additional resources please see Moving from a master branch to a version branch
  • I'm a bit confused, Is this some kind of Bartik sub-theme? Seems like you are using the same files, functions on template.php have this function bartik_process and tpl's too.
  • Your project page is not very detailed (usage, installation, screenshot?), please have a look at the tips for a great project page, you may also use HTML-tags for better structure.
  • Should provide a README.txt
  • Errors on comments formatting
  • Your CSS files should follow coding standards, i.e. Multiple selectors should each be on a single line, with no space after each comma, or each property should be on its own line
  • You should run your code through http://ventral.org/pareview, there are errors of style.
myshofer’s picture

myshofer commented

hi thanks for these suggestions.really helpfull.

zymphonies-dev’s picture

zymphonies-dev commented
StatusFileSize
new content_wrapper.png45.36 KB
new footer.png4.73 KB
new article.png44.74 KB
new footer_spacing.png12.25 KB

HI,
Manual Review:
Please fix these following UI bugs.
1) Give wrapper 20px bottom padding.

#wrapper { padding-bottom: 20px; }

2) align article page element properly (left align).
3) region-footer is going out of the frame.
4) Increase content wrapper width in inner page.
( attached screenshot for 1,2,3,4 points )

thanks
shanidkv

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes

added project info