Will this module be available on Drupal 7?

Thanks!

CommentFileSizeAuthor
#7 role_help-drupal-7-port-1516522-7.patch12.63 KBgeodaniel
#1 role_help.tar_.gz11.31 KBa_lawry

Comments

a_lawry’s picture

a_lawry commented
StatusFileSize
new role_help.tar_.gz11.31 KB

Initial drupal 7 port attached.

joachim’s picture

joachim commented

That's brilliant, thanks!

The output doesn't work yet due to the theme functions needing changing too, but this is a great start.

I've committed the whitespace and code style fixes to both branches as a preliminary patch, and then the rest as the start of a D7 branch.

Few tweaks I've made:

- 'project' shouldn't be used in the .info file
- hook_uninstall can go completely now it's empty

Follow-ons:

- theme system changes
- clean up _role_help_menu_access(). I've no idea why I had two queries in the 6.x branch! Also, we can grant access for authenticated users without doing the query to check for anon users, which is a small performance saving. And I'm suspicious of that ->fetchObject() query result.
- I'm pretty sure that checking $form_state['values']['op'] to know which button was pressed is really definitely deprecated on D7.

geodaniel’s picture

geodaniel commented

I've just tested out the D7 branch from Git and it looks to work as advertised.

It'd be good to list this as at least a dev release on the module homepage.

joachim’s picture

joachim commented

Good point. Done.

I've also marked this as needing a new maintainer, as it's completely dropped off my radar! Should anyone be interested, please file a new issue to request access :)

geodaniel’s picture

geodaniel commented

Great, thanks. I'm just working through some fixes on the 7 branch at the moment, and will post a patch when finished.

geodaniel’s picture

geodaniel commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Active » Needs work
geodaniel’s picture

geodaniel commented
Status: Needs work » Needs review
StatusFileSize
new role_help-drupal-7-port-1516522-7.patch12.63 KB

The attached patch fixes up some remaining issues I spotted in the Drupal 7 port:

  • adds more text to the message shown on install to mention the settings page
  • fixes links to role admin pages
  • handles role deletion and bypasses Drupal core role update to avoid duplicate messages
  • allows summaries to be entered for anonymous and authorised users (though anonymous user summary isn't exposed anywhere yet)
  • used the DRUPAL_ANONYMOUS_RID and DRUPAL_AUTHENTICATED_RID constants for role IDs
  • removes unused Drupal 6 code
  • moves global $user to the top of any function it's used in
joachim’s picture

joachim commented

Looks good on a quick eyeball review, but I'd recommend making those changes as several commits so it's clearer what's changed.

geodaniel’s picture

geodaniel commented
Status: Needs review » Fixed
Related issues: +#2178085: Remove unused Drupal 6 code, +#2178073: Fix role creation / deletion workflow, +#2178065: Improve and fix help text links, +#2178061: Add help text for the authenticated user role on user edit page., +#2178057: Use constants for built-in role ID values instead of numbers

I've separated these all out into different issues to make it a bit clearer what's going on.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.