As the title says :)

CommentFileSizeAuthor
wsclient_remove_cruft.patch3.58 KBamateescu

Comments

klausi’s picture

Title: Remove some cruft code (remote entities support) » Remove remote entities support (unused cruft)
Assigned: Unassigned » fago
Status: Active » Needs work

Yes, this is a start, but there is more to remove:

  • hook_menu()
  • grep for "entities", that should be removed from the service definition.
  • WSClientServiceEntityController

Also some reasoning: the remote entity support was never really used and never took off. So if you rely on that code for whatever reason now it would be a good time to speak up ;-)

Also assigning to fago, as I would like his signoff on what we are doing here.

fago’s picture

I'm fine with that, as said it's unused. Imho it's the right direction to pursue though - in particular for RESTful resources e.g. as done as example here: http://drupal.org/sandbox/fago/1493180 . The same way, it would be awesome to have wsclient data as entities, thus being able to list the data in Views, reference it using entityreference, index it using search-api, ...

Still, I guess the code should be removed until its used somehow ;)

klausi’s picture

Priority: Normal » Major
Issue tags: +D7 stable release blocker

tagging.

derekw’s picture

The code removed by this patch was also breaking Commerce product type custom display modes.

jpstrikesback’s picture

After updating Entity API to 1.0 it seems there is something in the above removed invocations / whatnot that borks custom displays, after applying this many undefined index CUSTOM DISPLAY notices are fixed...

Scratch that, it's back...also reverted to Entity rc3 and no dice...

Update: Downgraded DS to 2.0 from dev and that seems to have fixed it, sorry for polluting this issue...

mrfelton’s picture

Without this patch, wsclient causes memory issues when used in conjunction with og_features.

klausi’s picture

Status: Needs work » Fixed

Finally found the time to remove hopefully all the unused stuff. Committed to dev, please test!

Automatically closed -- issue fixed for 2 weeks with no activity.