Closed (fixed)
Project:
Web service client
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
5 Apr 2012 at 17:41 UTC
Updated:
4 Jan 2014 at 01:39 UTC
Jump to comment: Most recent
Comments
Comment #1
klausiYes, this is a start, but there is more to remove:
Also some reasoning: the remote entity support was never really used and never took off. So if you rely on that code for whatever reason now it would be a good time to speak up ;-)
Also assigning to fago, as I would like his signoff on what we are doing here.
Comment #2
fagoI'm fine with that, as said it's unused. Imho it's the right direction to pursue though - in particular for RESTful resources e.g. as done as example here: http://drupal.org/sandbox/fago/1493180 . The same way, it would be awesome to have wsclient data as entities, thus being able to list the data in Views, reference it using entityreference, index it using search-api, ...
Still, I guess the code should be removed until its used somehow ;)
Comment #3
klausitagging.
Comment #4
derekw commentedThe code removed by this patch was also breaking Commerce product type custom display modes.
Comment #5
jpstrikesback commentedAfter updating Entity API to 1.0 it seems there is something in the above removed invocations / whatnot that borks custom displays, after applying this many undefined index CUSTOM DISPLAY notices are fixed...Scratch that, it's back...also reverted to Entity rc3 and no dice...
Update: Downgraded DS to 2.0 from dev and that seems to have fixed it, sorry for polluting this issue...
Comment #6
mrfelton commentedWithout this patch, wsclient causes memory issues when used in conjunction with og_features.
Comment #7
klausiFinally found the time to remove hopefully all the unused stuff. Committed to dev, please test!