The call back to replace or remove other tags (lines 148-150 of emogrifier.module) is removing the space before a valid tag (like <strong>).

E.g.:

  • Before: <p>A valid tag is <strong>strong</strong></p>
  • After: <p>A valid tag is<strong>strong</strong></p>
CommentFileSizeAuthor
#7 emogrifier-1516920-7.patch1.19 KBplach
#3 emogrifier-do-not-strip-spaces-1516920-3.patch1.59 KBpillarsdotnet
#2 Removing-valid-spaces-1516920-2.patch601 bytestomgf
#1 Removing-valid-spaces-1516920-1.patch602 bytestomgf

Comments

tomgf’s picture

tomgf commented
StatusFileSize
new Removing-valid-spaces-1516920-1.patch602 bytes

I have produced a patch, knowing that perhaps it is just solving my issue…

Any comments will be appreciated.

Thanks!

tomgf’s picture

tomgf commented
StatusFileSize
new Removing-valid-spaces-1516920-2.patch601 bytes

I am sorry but the first patch I have submitted has an error…

This second one has what I have attempted to do in the first place.

pillarsdotnet’s picture

pillarsdotnet commented
Assigned: Unassigned » pillarsdotnet
Status: Active » Needs review
StatusFileSize
new emogrifier-do-not-strip-spaces-1516920-3.patch1.59 KB

Could you please test the attached patch?

tomgf’s picture

tomgf commented

I have tested your patch and –as it is including the lines I have provided– it also solves my problem… (no space before <strong> tags)

But we will probably need a more extensive test, right?

pillarsdotnet’s picture

pillarsdotnet commented
Version: 7.x-1.17 » 7.x-1.18
Status: Needs review » Fixed

Fixed in 6.x-1.18 / 7.x-1.18 / 8.x-1.18 releases.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new emogrifier-1516920-7.patch1.19 KB

Here is a 6.x version.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Forget #7, sorry, I didn't see this was fixed also in 6.x.