Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Split off the folder creation as this is causing all tests to fail for cmi upgrade patches.
Comment | File | Size | Author |
---|---|---|---|
#13 | update-test-create.patch | 1.21 KB | marcingy |
#5 | drupal8.test-config.5.patch | 2.25 KB | sun |
simpletest-config.patch | 474 bytes | marcingy | |
Comments
Comment #1
marcingy CreditAttribution: marcingy commentedComment #2
marcingy CreditAttribution: marcingy commentedSee http://drupal.org/node/1500312 and http://drupal.org/node/1496510#comment-5810546 - the second issue the patch above was added to make the tests pass.
Comment #3
Rok Žlender CreditAttribution: Rok Žlender commentedLooks good.
Comment #4
catchCommitted/pushed to 8.x, thanks!
Comment #5
sunThis change was wrong.
We don't want to automatically (re-)create the config directory on every single request.
SimpleTest actually attempts to create the config directory for the test site already, but apparently, it's entirely bogus, and if you happen to run a couple of tests in your D8 site, you will quickly see that a lot of config_23823t823t8ho directories are piling up in your public files directory.
Thus, the bug is that there's a directory name mismatch, and that needs to be fixed instead.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedoh boy. yep, that fix is totally bogus. sun's fix looks good to me.
Comment #7
catchOuch, committed/pushed the follow-up.
Comment #8
sunWhile #5 is definitely more correct, something still bugs me, but I don't know what. If you have a clue, feel free to re-open this issue or link to a follow-up. Thanks :)
Comment #9
catchIt feels to me like since the config directory is within the files path, that we shouldn't really need special handling at all - i.e. the config system ought to be able to make the directory itself, but I'm assuming there's a good reason for that.
Comment #10
sunNote, the config system never creates the config directory itself -- during a regular installation, it's the Drupal installer that creates the config directory.
Since the child site for a test run is not installed through the regular Drupal installer, this regular setup of the config directory doesn't happen either, so DrupalWebTestCase::setUp() creates it manually. This (and many similar issues) will go away once we've resolved #1215104: Use the non-interactive installer in WebTestBase::setUp() (which is still blocked on a range of dependencies currently)
Comment #11
catchRight, I mean if the installer creates the files directory, since the config directory is inside that, then it seems possible for the config backend to handle the directory creation. However it's quite a long way down the list of things to worry about with the installer ;)
Comment #12
marcingy CreditAttribution: marcingy commentedI am reopening this issue because we call
but that does not actually create the simpletest directory so although we have a simpletest namespaced path we do not actually have a config dir to write too.
Found while looking at test failures for #1496534: Convert account settings to configuration system
Comment #13
marcingy CreditAttribution: marcingy commentedThe folder was not being created for update tests.
Comment #14
sunThis code was heavily simplified in #1541958: Split setUp() into specific sub-methods very recently. Let's fix the upgrade path test setup over there.
Comment #15.0
(not verified) CreditAttribution: commentedClarify what is causing issues