Implement _token hooks in Node Relativity

Sorry - I don't use relativity.

In Pathauto5.x-2 the token module is used to create patterns, so if it implements the token hooks then Pathauto should be able to do something with it.

I realize now that was a little obtuse - when I said I don't use it I just mean that I have no idea how/if/where it could or would work with pathauto.

Also, if relativity doesn't work with pathauto then that should be lodged as a feature request for relativity - not with Pathauto.

To the maintainer of relativity - there is an API.txt in the pathauto module and if you have questions on how to implement it I can answer them.

Indeed, the proper place to implement either (or both) the _pathauto and _token hooks is in the Node Relativity module.

Please don't change this back to the Pathauto queue.

Also, this is a feature request for that module. There is no "support" needed in this situation. The work to be done is clear to anyone who has taken the time to read the API documentation included in both of the modules.

http://drupal.org/node/152287 has some ideas about the same issue.
Just to prevent work duplicates, I will start with token support in relativity.

I thought about implementing simple token support and then enhance it.

According to greggles: pathauto will be able to "talk" to token module, I see no use to integrate with pathauto and token.
Token support will be enough.

Committed to 2.x-dev.
If enough people said it's OK then the next release of 2.x will witness this feature.

Thanks, Omar. Question: do we need these settings of values to empty?

+      $values['parent-nid']            = ''; 
+      $values['parent-title']          = ''; 
+      $values['parent-type']           = ''; 
+      $values['parent-type-name']      = ''; 
+      $values['parent-author-uid']     = ''; 
+      $values['parent-author-name']    = ''; 
+      $values['parent-yyyy']           = ''; 
+      $values['parent-yy']             = ''; 
+      $values['parent-month']          = ''; 
+      $values['parent-mon']            = ''; 
+      $values['parent-mm']             = ''; 
+      $values['parent-m']              = ''; 
+      $values['parent-ww']             = ''; 
+      $values['parent-date']           = ''; 
+      $values['parent-day']            = ''; 
+      $values['parent-ddd']            = ''; 
+      $values['parent-dd']             = ''; 
+      $values['parent-d']              = ''; 
+      $values['parent-mod-yyyy']       = ''; 
+      $values['parent-mod-yy']         = ''; 
+      $values['parent-mod-month']      = ''; 
+      $values['parent-mod-mon']        = ''; 
+      $values['parent-mod-mm']         = ''; 
+      $values['parent-mod-m']          = ''; 
+      $values['parent-mod-ww']         = ''; 
+      $values['parent-mod-date']       = ''; 
+      $values['parent-mod-day']        = ''; 
+      $values['parent-mod-ddd']        = ''; 
+      $values['parent-mod-dd']         = ''; 
+      $values['parent-mod-d']          = ''; 
+      $values['parent-menu']         = '';
+      $values['parent-menupath']     = '';

If yes, then can't you write it as loop through all the keys (from relativity_token_list, for example). This repeats a lot of lines, and relativity.module is already too long and hard to understand...

You caught me. :)
I think we need to set the values to empty and yes it's a good idea to write more compact code.
I was trying in my patch to mimic token_node.inc which is working in a similar way and with a similar code structure. ;)

Unfortunately, pathauto will not support tokens untill 2.x version is out (which is currently under development).
So right now we will be able only to support token module.

Grrr, let's clarify my last post:
Greggles informed me that only pathauto 2.x will be able to read tokens from token module.
And as you see, pathauto is still in 1.x, thus currently there won't be support for pathauto module in relativity.
(Hope it's clear now)

Well, kinda...

Pathauto 5.x-2 is in development and is available for testing: http://drupal.org/node/129349

In my tests it works reasonable well, but there are certainly some known bugs (even critical ones).