Google+ Page Badge Block [#1517856]

Google+ Page Badge Block

This module allows you to place a Google+ Page Badge within a Block. The Google+ Page Badge is different than the Google +1 modules in that this module simply links to a page in Google+. Google+ allows users to create their own custom pages for companies and organizations.

This module simply allows the user to specify the Page ID, select one of three styles of page badges, and select a light or dark theme for the background of the badge.

After installing, update your settings for this module and activate the block.

All code related to the badge itself is supplied by Google+.

Sandbox: http://drupal.org/sandbox/edwardmonk/1517806
Core: 6.x

Comment	File	Size	Author
#1	googleplusbadgeblock.txt	4.68 KB	soncco

Comments

Comment #1

soncco commented 6 April 2012 at 14:36

Status:

Active

» Needs review

Status	File	Size
new	googleplusbadgeblock.txt	4.68 KB

Welcome!

IMHO, in https://developers.google.com/+/plugins/badge/ you can get the code and settings for the badge and a module is not necessary for it. However we can wait for the opinion for other user, my opinion is not for discouraged, but is just an observation :).

Somme issues:

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

README.txt is missing, see the guidelines for in-project documentation.
Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

Comment #2

edwardmonk commented 6 April 2012 at 15:14

I agree that it is fairly easy to just grab the code from the Google+ Badge page, that is where I got the code.
Not all users of Drupal have the skills necessary to implement the code easily. Once the module is installed, this module gives the non-technical person the ability to control the placement of the badge through the Block system. It also makes it easy to switch between badge types and themes without having to touch the code every time they want to make a minor change.

I will review the report, take a look at the git issue, and add a README.txt file.

Thank you for your input.

Comment #3

migmedia commented 10 April 2012 at 07:07

Wouldn't it better to make the googleplus-id user-dependend? In your implementation there can only one g+ account connected per drupal-installation.
What about sites with multiple-user?
Maybe Project User Variable helps you.

An other thought: Better be verbose on your project-page. No-one reads README-s ;-)

Micha

Comment #4

novalnet commented 24 April 2012 at 11:27

Hi,
Manual Review :

1. all functions should be prefixed with your module/theme .You should change the below functions,
function google_pluspagebadge_help($path, $arg) {
function google_pluspagebadge_perm() {
function google_pluspagebadge_block($op = 'list', $delta = 0, $edit = array()) {
function google_pluspagebadge_menu() {
function google_pluspagebadge_admin() {

2. google__page_badge_block.info :
"description" property & "core" property is missing in the info file.

Thanks

Comment #5

bloke_zero commented 25 April 2012 at 10:40

Status:

Needs review

» Needs work

Hi,

More review ;-)

I think the directory structure needs rationalising so that it's just one directory not google__page_badge_block/google_pluspagebadge but just google_pluspagebadge. If it was a suite of modules with a core admin interface I could see the current directory structure, but not for a simple module like this.
Would it be better to add this: <script type='text/javascript' src='https://apis.google.com/js/plusone.js'></script> via drupal_add_js()?
This would be a good candidate for a block that you can configure from the block page using the block configure link: i.e $op == 'configure'

Cheers

Alex