Closed (won't fix)
Project:
Workflow
Version:
5.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Jun 2007 at 16:09 UTC
Updated:
14 Nov 2011 at 15:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
mrsocks commentedI dont fully understand why the menu shows up on the uncategorized node pages, but I have figured out how to fix it from showing FOR MY INSTALL.
I had to change the workflow_help function to:
First, per php, there should be a 'break;' after each case check otherwise it continues to process the rest of the cases.
Then: case strstr($section, 'admin/build/workflow/edit'):
would actually return: admin/build/workflow/edit...............and anything after the needle (the second para in the strstr function)
so, yes, it is matching the whole $section string like it should BUT i dont know enough about the drupal hook system to know why this is happening.
Anyway,
so i made the hook more dependant on specific vals by exploding and using the two specific vals for the array of the url.
This WONT work if you move the install to a new dir. like domain.com/drupal/
SO THIS IS A HACK that works for me.
Comment #2
ashearer commentedI ran into the same issue. Here's a smaller patch that also works: add the indicated two lines after the switch. The strstr case always matches when compared against an empty section, so the new case prevents it from being reached.
Comment #3
ashearer commentedPatch version of the above. Tested with Drupal 5.2 and PHP 5.2.2 on Linux.
Comment #4
JacobSingh commentedI can't confirm the bug, nor can I see how it can be reproduced. If someone can provide a step by step on how to make it happen, I'll commit this.
Comment #5
SolomonGifford commentedI have the same problem...for me it only shows up on 404 pages...adding the case '':break; solved the problem for me.
Comment #6
Bastlynn commentedHi,
With the release of Drupal 7, Drupal 5 is no longer receiving security updates, reviews, or development from many contributed modules. Since 5 is now considered a depreciated version, you really should seriously look into upgrading to Drupal 6 or 7. The newer versions of Drupal work better, have more support, and will be safer (literally! security patches!) for your website. We are currently working on a new release for Workflow to Drupal 7. In light of that, further support for Drupal 5 issues is infeasible at the moment. Please consider upgrading to Drupal 6 or 7 in the near future - you'll be glad you did.
- Bastlynn