Being able to save my lookup history and display previous lookups in a Whois block would be fabulous. Even having a global history would be helpful.

Great module. Thanks!

CommentFileSizeAuthor
#3 whois_store_data.patch3.99 KBobsidiandesign

Comments

Gurpartap Singh’s picture

Version: 5.x-1.x-dev » 6.x-1.0

Added watchdog logging in 6.x version.

If someone can take up with the above suggested feature, patches are welcomed anytime! :-)

obsidiandesign’s picture

Status: Active » Needs work

The attached patch will store the data in the database and allow the admin to return a cached result over a specified time period. One issue is that the storage relies on the cache time, as the result will be stored every request if the cache time is set to 0.

I'm working on the block next, hope to have a separate patch tomorrow or Saturday. I'm working on this for a client project, so he's agreed to contribute the work back to the modules.

Bryan O'Shea
Obsidian Design

obsidiandesign’s picture

StatusFileSize
new3.99 KB

Forgot to attach the patch, sorry.

giorgio79’s picture

Thanks for this :)

Was the block part ever finished? :)

giorgio79’s picture

It seems the patch does not apply anymore, will try to reroll it

patch < whois_store_data.patch
(Stripping trailing CRs from patch.)
patching file whois.install
Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file whois.install.rej
(Stripping trailing CRs from patch.)
patching file whois.module
Hunk #1 FAILED at 85.
Hunk #2 FAILED at 197.
2 out of 2 hunks FAILED -- saving rejects to file whois.module.rej

helmo’s picture

Status: Needs work » Postponed

A generic cache feature has been added in the meantime.

Even though a history list of past lookups seems cool I fail to see a business case for it.
Keeping an eye on the watchdog system would suffice for now...

helmo’s picture

Status: Postponed » Postponed (maintainer needs more info)