On tables with multiple lines in the header, the bottom border of the sticky header isn't consistent (see attachment).

To reproduce this, switch to a fixed width theme (chameleon, Minnelli), or reduce the width of the browser window. Go to the access page and make sure some headers are on several lines. create a few roles if necessary. Reload the page and scroll down.

CommentFileSizeAuthor
#3 tablehearder-height.patch846 bytesscor
#2 tableheader_bug.png23.27 KBscor
#1 drupal.stickyheader.patch830 bytesscor
bugheader.png1.81 KBscor

Comments

scor’s picture

scor commented
Status: Active » Needs review
StatusFileSize
new drupal.stickyheader.patch830 bytes

This patch adds the height of the sticky div according to the height of the cell. Tested with garland, chameleon and Minnelli on FF.

scor’s picture

scor commented
StatusFileSize
new tableheader_bug.png23.27 KB

this issue is still in core.

scor’s picture

scor commented
StatusFileSize
new tablehearder-height.patch846 bytes

patch rerolled...

kkaefer’s picture

kkaefer commented
Status: Needs review » Needs work

Doesn't solve the issue in Safari (at least).

JirkaRybka’s picture

JirkaRybka commented

The solution here is incomplete, as the size may change on window-resizes with text wrapping, and I even encountered inconsistencies between cell heights in the same row (FF 2.0.0.6 / Linux).

There's another related issue (column 1 hidden behind the rest, if the content is aligned to center or right), and even more problems with tableheader.js: http://drupal.org/node/194590 - In #12 there, I just attached my patch. Needs cross-browser testing.

Edit: I played with that patch quite a while, and now it REALLY needs testing: http://drupal.org/node/194590

scor’s picture

scor commented
Status: Needs work » Closed (duplicate)

http://drupal.org/node/194590