Follow up. Now that we have #1174640: Add new HTML5 FAPI element: number it's time to use the new element type.
That is:

  • Replace element_validate_integer() with '#type' => 'number'. Default step is 1, so nothing special for integers.
  • Replace element_validate_integer_positive() with '#type' => 'number', '#min' => 1. Default step is 1, so nothing special for integers. Negative numbers and zero are not allowed, so the minimum is 1.
CommentFileSizeAuthor
#7 1519720-use-number-7.patch7.45 KBNiklas Fiekas
#7 1519720-use-number-7-interdiff.txt1.58 KBNiklas Fiekas
#1 1519720-use-number-1.patch6.4 KBNiklas Fiekas

Comments

Niklas Fiekas’s picture

Niklas Fiekas commented
Status: Active » Needs review
StatusFileSize
new 1519720-use-number-1.patch6.4 KB

First try.

Status: Needs review » Needs work

The last submitted patch, 1519720-use-number-1.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas commented
Status: Needs work » Needs review
StatusFileSize
new 1519720-use-number-7-interdiff.txt1.58 KB
new 1519720-use-number-7.patch7.45 KB

Ok, poll module tests caught the changed error messages. While fixing that I also found "custom" non-negative validation, that can be replaced with '#min' => 0.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

I love this cleanup!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Nice clean-up indeed. Better developer experience. Committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

marcingy’s picture

marcingy commented
Title: Remove element_validate_integer() and element_validate_integer_positive() in favor of the new number element type » Change notification : Remove element_validate_integer() and element_validate_integer_positive() replace with number element type
Priority: Normal » Critical
Status: Closed (fixed) » Active

Re-opening as this needs a change notification

Niklas Fiekas’s picture

Niklas Fiekas commented
Title: Change notification : Remove element_validate_integer() and element_validate_integer_positive() replace with number element type » Remove element_validate_integer() and element_validate_integer_positive() replace with number element type
Priority: Critical » Normal
Status: Active » Fixed

Well spotted. Fixed: http://drupal.org/node/1678914.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fix typo.