Needs review
Project:
Ogone | Ubercart payment
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
7 Apr 2012 at 10:23 UTC
Updated:
25 Nov 2012 at 10:36 UTC
Jump to comment: Most recent file
Comments
Comment #1
bartezz commentedVery nice! I will try and see if I can test this any time soon. Just switched employers and am very busy.
But will do my best!
Cheers
Comment #2
Biolin commentedrobbertnl
I have tested both 6.2 rc1 and your Dev version.
I am using i18n for my multilingual web site http://www.biolin.com
I am running the last version of Drupal in 6.2.x
1) just after installation of the module, I receive the following error message :
(see image #1 of the attached file)
2) "Wrong datatype for second argument on the line 504 of uc_ogone_payment.module on line 504
on image #2 in the here attached document, I have included the details of the line 504 !
3) With (as far as I can see ) correct settings on the OGONE interface .... when payment is performed by a customer ... the payment goes trought BUT :
- it is mention in the order Status column "Paypal in progress" ... it should be mention OGONE and not paypal ... Paypal was not even selected during the payment process.
- When I go to check how the payment I did look like I can see that the amount was submitted to Ubercart TWICE !!! ... see image 4 ... this is definitly not normal.
- When checking if the transactiopn went fine at Ogone side ... I saw that it was OK ...
- I then went into Ubercart parameters and values ... I can see that the payment was absolutly not updated after payment with OGONE.... How can I fix this this is very frustrating.
It looks like the STATUS is ok
It looks also that OGONE did not notify us that the status was changed (surprising as we do receive your files.
For info, we also receive message from OGONE with an error see image.
In fine OGONE does not update the credit card status when something is paid ..
please advise
Comment #3
robbertnl commentedHi Biolin,
Thank you for your detailed report.
I am sorry to hear you are having problems with this module.
Please be aware that it was still a release candidate and nobody else tested (or didnt notify me) this branch.
Second, i am not working for Ogone i just made this release and contributed it here. That means i am contributing to this module in spare time.
1) and 2) seems to be a relative simple bug. I guess its fixed by excluding a payment method in the configuration. But this should be fixed in code.
3) Payment will just go to the next default payment step as configured in Drupal. I think thats set to Paypall in your configuration. So either that should be changed or code should be changed to introduce a new payment step when the module is installed.
I dont have payments twice. Please double check delayed payment request from Ogone. I think now the payment gets registered twice becuase its redirecting and after that the ogone service sends a payment call.
What do you mean with:
- I then went into Ubercart parameters and values ... I can see that the payment was absolutly not updated after payment with OGONE.... How can I fix this this is very frustrating.
You said before that you had the payment twice but now you dont have any?
Comment #4
Biolin commentedHi Robbertnl,
Sorry for late reply to the following ...
I did completly removed tyhe OGONE module I had on my side here and this in order to find out what was going on.
I reinstalled everything beck from scratch with your dev release and this is what I am using in production envir.
Everything seems to work fine besides somes details that are quiet embarrasing .
I just don't know where to look to find the exact origin of the problem I am actualy facing.
In fact, my Ubercart does not receive the feedback from OGONE that the payment was successfull and neither update the status of the order.
for info :
a) All IP addresses from ogone are allowed in my firewall so this point is not the cause.
b) the Feedback status is well leaving OGONE when the payment is complete ....
SO, my problem is that Ubercart does not receive the handshake from Ogone and does not update his order status....
The order remains in his first stage in Ubercart ... and so of course the customer does not receive the mail that the order is complete. .... He only receive that when I manualy validate the order.
Linked to this problem but in fact coming first in the thing I noticed : When entering my credit card information at Ogone to perform the payment ... everything work as expected but when the payment is completed ... Ogone sends me to a page called like this ;
http://www.biolin.com/fr/cart/ogone_return_ok?orderID=2497¤cy=EUR&...
BUT that page remains blank on our side like if she did not exist ?!!!!
Important remark : I am using Ubercart in a multilinguage site and I did respect the fact that feedback url should respect the following :
Post payment URL: absolute path to /cart/uc_ogone_update_status
BEWARE i18N sites: The above URL will throw a 301 redirect and kill the post payment process by Ogone
Prepend the url with the language code. E.g. en/cart/uc_ogone_update_status
any help or recommendation are welcome because apparently this is for me the 2 only problem for this dev module.
I would be please to help but unfortunalty I cannot code :-(
Comment #5
Biolin commentedHi Robbertnl,
Here are some updates about my testing, hope they will help.
On my side there is only one blocking stage regarding your dev module and one detail one.
NB & Important for all probably : My previous message was mentionning that everything was working fine beside the dialog between OGONE and our Drupal/Ubercart server ....
a) as a matter of fact even if they where correct I changed the SHA-1 40 character signature with a 64 random hexadecimal characters from : https://www.grc.com/passwords.htm
immediatly after that communication was established again between OGONE and our server !!! (wierd but that worked )
b) as allready mentionned ealier ... the entire completion of the order is still an issue and I don't know from where it is coming from ... It seems like Ogone send 2 times the information that the order was paid and so I you go to the Store payment part of Ubercart in /admin/store/orders/ordernumber
1) I can see that the balance is a negative value (see image capture1.png here attached) like if we own money to the customer !!
Whe I click on View to see the payment page ( /admin/store/orders/ordernumber/payments
2) I can see the effectively the payment was entered 2 times in Ubercart !! (see image capture2.png here attached)
The status of the order on the general orders page ( /admin/store/orders/view ) is also strange (little bug in my opinion) as it shows : Paypal in progress ... and we know that we have used Ogone to perform that payment.
(see image capture2.png here attached) ... I don't understand WHY this is happening.
Could you help solve those last issues ?? or guide me to point where things should be changed in the code in order that :
A) Ogone send only owner payment notification.
B) that the order is finalized and Done and balance come back to "Zero" because the order was effectively paid.
thank you.
Comment #6
robbertnl commentedHi Biolin,
Thanx for your detailed report. At the moment i am kinda busy, i will take a look later, but maybe someone else can take a look as well
Comment #7
Biolin commentedThanks Robbertnl I will try to see if Barteez can eventualy give me some advise about this
Comment #8
bartezz commentedHi Biolin,
Received your email but have been real busy lately. End of the year and everyone wanting to have their project finished before the new year...
In your email you wrote you have a PayPal payment module enabled as well. Disable all payment modules except Ogone and get that working first . I have attached the version I'm using. Can't really spare the time te help you debug your issues. But maybe try attched version and see if it helps!
Good luck mate!
Cheers